Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve token permissions parsing #58

Open
gillchristian opened this issue Jul 10, 2020 · 0 comments
Open

Improve token permissions parsing #58

gillchristian opened this issue Jul 10, 2020 · 0 comments
Labels
agent

Comments

@gillchristian
Copy link
Member

There are a few things to improve in the token permission(s) parsing now.

  • We default to JobWrite but docs state we don't (I think this is good expected behavior)
  • We ignore failure to parse any permissions
  • We use "serde_json" meaning we need to do some formatting of the data in order to parse it as valid JSON
  • As we add more permissions in the token it will probably make sense to add a better documentation for them in the CLI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gillchristian