Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync: PartyBase Lifetime #900

Closed
3 tasks
garrettluskey opened this issue Aug 10, 2024 · 1 comment · Fixed by #973
Closed
3 tasks

Sync: PartyBase Lifetime #900

garrettluskey opened this issue Aug 10, 2024 · 1 comment · Fixed by #973
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@garrettluskey
Copy link
Contributor

Description

  1. Sync the values in the Synced list below.
  2. Create an end to end (E2E) tests for this lifetime sync (1 from the server side and 1 from the client side. Client test should not create object)
  3. Create a command to create and delete (if applicable) the synced object see similar command

Also see additional information at the bottom for more information and templates

Intended Design

For the patch itself please refer to https://github.com/Bannerlord-Coop-Team/BannerlordCoop/wiki/Patching-Basics#collection-patching

Lifetime Sync Dataflow
LifetimeSyncDataflow

Location

Create a branch based from development

Related Issues

N/A

Requirements

N/A

Additional information

Using the GameInterface Service Tempale create commands to test the synced values.

Definition of Done

  • Class level comments exist for all new classes.
  • XUnit E2E tests exist for every synced collection on the server (and client if applicable)
  • Each collection has a command for each type of synced update
@georgyrudnev
Copy link
Contributor

I believe this merge/commit kinda changed behaviour of #818 since the village bug is not ocurring in villages anymore but in settlements instead. Also now after clicking wait here in settlement it is not possible to enter any other settlement in the game anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants