Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync: SiegeEvent.SiegeEngineMissile Fields #1017

Open
3 tasks
garrettluskey opened this issue Oct 16, 2024 · 0 comments
Open
3 tasks

Sync: SiegeEvent.SiegeEngineMissile Fields #1017

garrettluskey opened this issue Oct 16, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@garrettluskey
Copy link
Contributor

Description

  1. Sync the values in the Synced list below.
  2. Create an end to end (E2E) tests for all fields (1 for server changing the value and 1 for client changing the value if applicable)
  3. Create a command to test changing each value in game see similar command

Also see additional information at the bottom for more information and templates

Key
Server side only (only allow the running of the function on the server side)
Client side only (only allow the running of the function on the client side)
Client side sync (request the server to change the value, server then changes the value and replies to the client allowing the change)
Server side sync (only server allows running of the function and send to all clients the value changed and clients update the value/call original function)

Synced

Method/Field Name Sync Type Additional Information
TODO TODO TODO

Deferred

None

Externally Deferred

None

Non-Synced

None

Intended Design

For the patch itself please refer to https://github.com/Bannerlord-Coop-Team/BannerlordCoop/wiki/Patching-Basics#field-patching

Field Sync Dataflow
FieldSyncDataflow
Integration Testing
image

Location

Create a branch based from development

Related Issues

Blocked by:

Requirements

N/A

Additional information

Using the GameInterface Service Tempale create commands to test the synced values.

Definition of Done

  • Class level comments exist for all new classes.
  • XUnit E2E tests exist for every property on the server (and client if applicable)
  • Each field has a command getter and setter that used the correct intercept
@garrettluskey garrettluskey added the enhancement New feature or request label Oct 16, 2024
@garrettluskey garrettluskey added this to the MVP milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Workable
Status: Todo
Development

No branches or pull requests

1 participant