Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capturing does not always work #150

Closed
juj opened this issue Apr 18, 2020 · 5 comments
Closed

Capturing does not always work #150

juj opened this issue Apr 18, 2020 · 5 comments

Comments

@juj
Copy link
Contributor

juj commented Apr 18, 2020

E.g. when visiting http://clb.confined.space/dump/PolyStyleMedievalVillage_20200418_065906_wasm_release_cpuprofiler/ for some reason Spector.js is unable to capture the page.

See video at
http://clb.confined.space/dump/SpectorJs_capturing_does_not_work.mov

It seems that Spector is unable to find the canvas on the page. It asks to select the canvas, but not quite sure how to exactly do it?

@sebavan
Copy link
Member

sebavan commented Apr 18, 2020

This is related to the thumbnails capture being pretty slow as capturing each of them is a pain and requires lot of extra copies to a canvas 2d before converting the picture to base64 to keep them serialized :-( You can use

image

which is less than ideal but can at least help seeing the command.

That said like on #151 I do not see how exploring the capturing can be manageable in 40 000 calls.

I guess the easiest in those app is to debug by relying on the npm package or we could reorganize the UI per Frame Buffer as it has been proposed once ? I am taking any idea where we could reduce the amount of visible info to make the navigation useful

@juj
Copy link
Contributor Author

juj commented Apr 18, 2020

Hmm, are you sure? Note that the missing canvas issue occurs already before I do a capture. Does Spector.js capture thumbnails already before clicking on capture?

To be precise, the issue here is not that capture takes a long time on the page, but that it often happens that one cannot even initiate taking a capture of the page, as the profiler gets stuck saying "please choose a canvas in the list" and no canvases show up in the list?

@juj
Copy link
Contributor Author

juj commented Apr 18, 2020

(I would not mind even if doing a full capture would take 10-20 minutes on such a long page)

@sebavan
Copy link
Member

sebavan commented Apr 18, 2020

Ohhhhh my bad, i was lucky on my couple tries then, i ll see if I can easily repro :-) thanks for the precisions.

@sebavan
Copy link
Member

sebavan commented Jan 18, 2022

I am not able to repro consistently, so the easiest here might be to use the npm package.

@sebavan sebavan closed this as completed Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants