Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle is an abomination #7

Open
3 tasks
The-Noah opened this issue Jan 22, 2021 · 1 comment
Open
3 tasks

Bundle is an abomination #7

The-Noah opened this issue Jan 22, 2021 · 1 comment
Labels
bug Something isn't working build Related to build script/process
Milestone

Comments

@The-Noah
Copy link
Member

The bundle emitted by Deno is an abomination.

  • Filled with garbage.
    • What in the world is this and why does it exist? The variables aren't even used.
const Zone1 = Zone;
const MeshPyramid1 = MeshPyramid;
const Base1 = Base;
const MeshBox1 = MeshBox;
const World1 = World;
  • Renames things it shouldn't.
    • bzw into mod, which has to be manually overwritten.
  • Modules lose their scope.
    • Such as dom and highlight.

Right now the bundle must be manually edited by the build script: build.ts#L34-L44

Possibly related: swc-project/swc#1349

@The-Noah The-Noah added the bug Something isn't working label Jan 22, 2021
@The-Noah The-Noah added this to the v1.0 milestone Jan 22, 2021
@The-Noah The-Noah added the build Related to build script/process label Jan 22, 2021
@The-Noah The-Noah pinned this issue Jan 22, 2021
@The-Noah
Copy link
Member Author

Updating to Deno v1.8.3 has mostly fixed the issue, however it is still partially there.

js = compress(files["deno:///bundle.js"].replace(/Pyramid1/g, "Pyramid").replace(/Box1/g, "Box"));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Related to build script/process
Projects
None yet
Development

No branches or pull requests

1 participant