Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR - Improvements for the /requests/{object_id}/update_status endpoint #241

Open
MonikaVo opened this issue Oct 11, 2024 · 0 comments

Comments

@MonikaVo
Copy link
Collaborator

  • The object_id in the URL is currently not forwarded to the endpoint and therefore, the object_id needs to be provided separately during the process. The data parameter in the curl command is empty, which appears unusual for an endpoint of type POST.
  • The "" character at the end of the endpoint seems unnecessary.
  • It is declared as a POST method, but it does not post anything to FINALES. Consider defning it as GET or add data to the call to this endpoint.

(This is based on some feedback we got and I hope, I correctly forwarded it.)

@MonikaVo MonikaVo changed the title Improvements for the /requests/{object_id}/update_status endpoint REFACTOR - Improvements for the /requests/{object_id}/update_status endpoint Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant