Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR - Do the de-referencing in the get_schema_template function #184

Open
MonikaVo opened this issue Jul 22, 2023 · 0 comments
Open
Milestone

Comments

@MonikaVo
Copy link
Collaborator

Having to de-reference definitions adds quite a substantial amount of extra logic to the already complex process of translating the schema (all the checks for $ref that you do below). I would advice to do the full de-reference separate before calling this function as a separate task, so all references are replaced by the actual sub-schemas and you don't need to worry about that here.

You can even use an existing tool like replace_refs from jsonref library (I am already using it for the limitations, see here).

Originally posted by @ramirezfranciscof in #182 (comment)

Preparations are already done in comments in the server_manager.py. However, this causes a comprehensive refactoring of the code.

@MonikaVo MonikaVo added this to the Test run #4 milestone Jul 22, 2023
@SKS94 SKS94 modified the milestones: Test run #4, FINALES 3 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants