Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker issue multiple course offering #1341

Closed
wants to merge 4 commits into from
Closed

Datepicker issue multiple course offering #1341

wants to merge 4 commits into from

Conversation

ali-ramazani
Copy link
Member

Datepicker Issue in Create Event Modal

Fixes #1333

  • The issue was when trying to use the datepicker to choose a date on an event with multiple offerings, the date picker would show below the modal. Initially, the assumption was the datepicker in the modal was triggering the datepicker outside of the modal. After hours of investigation, I concluded that the the correct datepicker was being displayed, but there was a z-index issue with the native datepicker module.

Changes

  • Disabled the default browser date picker.
  • Increased the z-index of the datepicker in the modal.

Testing

  • I verified the code works for both Chrome and Firefox, two major browsers.
  • I verified the responsiveness by adjusting the screen.

@ali-ramazani
Copy link
Member Author

However, there's another issue that needs to be fixed in another ticket. The dynamically added events in the modal refer to the first event.

@vungc vungc self-requested a review October 17, 2024 17:27
vungc
vungc requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@vungc vungc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are merge conflicts and causing the main page to not open properly. The initial issue also does not seem to be resolved, the datepicker is not working properly for multiple offering events. For example, if I add another event and I try to change the datpicker, it changes it for the first event always. I am not sure if this is because of the merge conflicts.

@github-actions GitHub Actions
Copy link

View Code Coverage

@WackyWeaver
Copy link
Contributor

It seems like there have already been changes made to the date picker inside of multiple time offering on development since this PR was started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vungc vungc vungc requested changes

Assignees

@ali-ramazani ali-ramazani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datepicker Pop-Ups on Multiple Event Offerings
3 participants
@ali-ramazani @WackyWeaver @vungc