Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Dependencies in Net Framework TokenCache package break Kestrel on Net Framework #1662

Open
stephenjust opened this issue Mar 18, 2022 · 3 comments · May be fixed by #1663
Open

[Bug] Dependencies in Net Framework TokenCache package break Kestrel on Net Framework #1662

stephenjust opened this issue Mar 18, 2022 · 3 comments · May be fixed by #1663
Labels
bug Something isn't working .net framework P2

Comments

@stephenjust
Copy link

Which version of Microsoft Identity Web are you using?
Microsoft.Identity.Web.TokenCache all versions

Where is the issue?

  • Token cache nuget dependencies

Is this a new or an existing app?
Existing app, trying to migrate to .Net Core via older Asp.Net Core release.

Repro
Install Microsoft.Identity.Web.TokenCache on a service using net472, and aspnetcore 2.1 or 2.2

Expected behavior
Installing the nuget package should not break aspnetcore

Actual behavior
Microsoft.Identity.Web.TokenCache pulls in packages from Microsoft.Extensions 5.0.0.
A change to Microsoft.Extensions.Primitives in this release breaks the Asp.Net Core versions that run on .Net Framework, essentially the Kestrel worker thread crashes.

Possible solution
Depend on a 3.1.x version of Microsoft.Extensions for Net Framework.

Additional context / logs / screenshots / link to code
dotnet/aspnetcore#28112 describes the issue in more detail. For projects stuck on .Net Framework for some reason or other, and those trying to modernize their codebases piecewise, this dependency issue is pretty frustrating.
@jmprieur
Copy link
Collaborator

jmprieur commented Mar 18, 2022 •
edited
Loading

@stephenjust:

  • do you have repro steps? How do we create an Asp.net core 2.1 or 2.2 on .NET FW application?
  • would you be willing to submit a PR?

@jmprieur jmprieur linked a pull request Mar 21, 2022 that will close this issue
Open
@stephenjust
Copy link
Author

You can repro this by cloning https://github.com/stephenjust/AspNetCore-FullFramework
You can start the project "WebApplication.Basic" in that repo's current state, then install Microsoft.Identity.Web.TokenCache which will cause AspNetCore to break. AspNetCore seems to be relatively tightly coupled to particular versions of Microsoft.Extensions.

@jayesh-a-shah
Copy link

Can you please make this change for net462 as well?

@jennyf19 jennyf19 added bug Something isn't working .net framework labels Nov 27, 2023
@jennyf19 jennyf19 added the P2 label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working .net framework P2
Projects
None yet
Milestone
No milestone
4 participants
@stephenjust @jmprieur @jennyf19 @jayesh-a-shah