Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApiVersionParameter's x-ms-parameter-location changed by TypeSpec conversion #1871

Open
mccoyp opened this issue Nov 14, 2024 · 0 comments
Open

ApiVersionParameter's x-ms-parameter-location changed by TypeSpec conversion #1871

mccoyp opened this issue Nov 14, 2024 · 0 comments
Labels
needs-area

Comments

@mccoyp
Copy link
Member

mccoyp commented Nov 14, 2024

I've been migrating a brownfield service, Key Vault, to TypeSpec (for example, the Secrets library migration PR: Azure/azure-rest-api-specs#29249). Operations are defined with Azure.Core.Foundations.Operation and automatically acquire an Azure.Core.Foundations.ApiVersionParameter.

This new ApiVersionParameter has an x-ms-parameter-location value of "method", which is a breaking change from KV's original API version parameter's x-ms-parameter-location value of "client".

This hasn't seemed to functionally affect clients generated from the new TypeSpec, but the breaking change did raise some concern from our team.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mccoyp