Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for Release - storage/stg95 blob&files preview #23632

Closed

Conversation

tanyasethi-msft
Copy link
Member

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to module CHANGELOG.md are included.
  • MIT license headers are included in each file.

@tanyasethi-msft tanyasethi-msft changed the title rep for Release - storage/stg95 blob&files preview Prep for Release - storage/stg95 blob&files preview Oct 22, 2024
@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Oct 22, 2024
@tanyasethi-msft tanyasethi-msft enabled auto-merge (squash) October 22, 2024 15:12
@@ -8,5 +8,5 @@ package exported

const (
ModuleName = "github.com/Azure/azure-sdk-for-go/sdk/storage/azfile"
ModuleVersion = "v1.3.2"
ModuleVersion = "v1.4.1-beta.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be v1.4.0-beta.1.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, thanks!

@@ -8,5 +8,5 @@ package exported

const (
ModuleName = "github.com/Azure/azure-sdk-for-go/sdk/storage/azblob"
ModuleVersion = "v1.4.2"
ModuleVersion = "v1.5.1-beta.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be v1.5.0-beta.1.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, thanks!

@tanyasethi-msft
Copy link
Member Author

Closing, since the '&' in the branch name could not be parsed by the pipelines. This PR is re created with the changed branch name

auto-merge was automatically disabled October 22, 2024 17:37

Pull request was closed

@jhendrixMSFT
Copy link
Member

@benbp is the & in a branch name known to be problematic?

@benbp
Copy link
Member

benbp commented Oct 22, 2024

@jhendrixMSFT this will be fixed by @praveenkuttappan, we're just missing some quotes in the yaml templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants