• feat(avm)!: store public bytecode compressed in artifact #11193 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Not sure if this will fly if it gets used in the browser. @Thunkar ?

Yeah indeed

 ERROR in ../types/dest/abi/contract_artifact.js 3:0-34
  Module not found: Error: Can't resolve 'zlib' in '/build-volume/yarn-project/types/dest/abi'
  
  BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
  This is no longer the case. Verify if you need this module and configure a polyfill for it.
  
  If you want to include a polyfill, you need to:
  	- add a fallback 'resolve.fallback: { "zlib": require.resolve("browserify-zlib") }'
  	- install 'browserify-zlib'
  If you don't want to include a polyfill, you can use an empty module like this:
  	resolve.fallback: { "zlib": false }

Gzipping reduces the public bytecode size ~50%. It would probably pay off to add a polyfill. WDYT?

we may want to make this lazy and hide it behind a property getter.

That's a good idea, will check it out.

and instead rely on native browser compression

Yeah this was kind of my point in the slack discussion. I think even if we compress like in this PR, browser compression will squeeze some gains over the base64 encoding etc.

I discussed with @Thunkar and he pointed me to the pako import that's browser friendly and being used in some other places already.

I'll consider all this but it might just be simpler to not compress and go with something like #11101 which would already reduce public bytecode 50%.