Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreEx versioning suggestion #55

Open
karpikpl opened this issue Jan 26, 2023 · 2 comments
Open

CoreEx versioning suggestion #55

karpikpl opened this issue Jan 26, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@karpikpl
Copy link
Collaborator

Hi,
I think this package could benefit from https://github.com/dotnet/Nerdbank.GitVersioning tool

Just for your consideration.
I could add that in to the pipeline.

@karpikpl karpikpl added the enhancement New feature or request label Jan 26, 2023
@chullybun
Copy link
Collaborator

Hey @karpikpl, I would be interested in learning more given the following...

At the moment the version is specified (manually) within the common.targets as an explicitly updated version. Then the CHANGELOG is updated and changes logged against that version. One or more commits, and/or branches/pull requests, may then result in the output of a specific (single) published version contain all changes. Would definitely not want every interim merged version published to NuGet.

Then finally there is the manual step, currently outside of GitHub, to publish using the nuget-publish.ps1 when finally ready (this step is planned to be managed via GitHub with secret API key for publish - at some point).

Cheers...

@karpikpl
Copy link
Collaborator Author

from what I can tell, this library provides few things:

  • adds git commit info to assemblies and build information
  • adds git id to preview versions
  • helps creating preview versions
  • version info is kept in version.json - either for entire solution or per project
  • automates branch creation for releases

other than that, nuget publish is still up to pipeline/developer.

I just found it interesting (also the fact that it's under github.com/dotnet)

feel free to close :) maybe we can revisit when pipeline work will happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants