feat: Add WindowCornerHintsProperty #17354
Open
+87
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
This API makes sense to me as part of Win32Properties class: https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Controls/Platform/Win32Properties.cs#L17. Not xplat. |
BAndysc
force-pushed
the
feat_corner_shape_hint
branch
from
ae30832
to
a996eda
Compare
Oh, I didn't know about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR adds a new
StyledPropertyto theWindowclass:WindowCornerHintsProperty, which provides hints for window corner appearance. The hint is only used on Windows, as only this platform supports controlling corner appearance.This is required for Classic.Avalonia theme to look good.
What is the current behavior?
Currently, there is no way to control window corners; it is up to Avalonia to decide which corner style to use.
What is the updated/expected behavior with this PR?
When
WindowCornerHintsPropertyis set todefault platform,round, ordo not round, the appropriate corner preference is used. However, by default,WindowCornerHintsPropertyhas the valueNoHint, which indicates that it is up to Avalonia to decide which corner style should be used. This way, the default behavior is the same as it is now.How was the solution implemented (if it's not obvious)?
This PR follows the implementation of
ExtendClientAreaChromeHintsProperty.Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #17294