Impl auto safe area padding #13047
Merged
Impl auto safe area padding #13047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
2 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Has this been removed in a recent version of Avalonia? With 11.3.999-cibuild0052531-alpha on iPhone SE 2nd gen (iOS 17) I get no automatic padding and my navbar is rendered across the system status bar:
Similarly in iPhone 15 Pro emulator (iOS 18):
|
|
|
@kerams can you open an issue with minimal repro? I can take a look over weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Adds a new
TopLevel.AutoSafeAreaPaddingproperty settable on the top-level content (MainView) or top-level itself.When enabled, it automatically adds safe area paddings.
Normally, to see any effect, it also requires InsetsManager.DisplayEdgeToEdge to be enabled as well, so application content can be rendered behind the status bar.
It is enabled automatically on iOS though, and we need to add safe paddings automatically. Making overall Avalonia iOS experience better out of the box.
It's a behavioral change on mobile, since TopLevel.AutoSafeAreaPadding is enabled by default now. If not needed, TopLevel.AutoSafeAreaPadding can be disabled on the main view.
Also, this PR changes iOS InsetsManager.SafeAreaPadding behavior to match Android behavior, when SafeAreaPadding returns empty paddings, when DisplayEdgeToEdge is disabled.
Fixed issues
Fixes #12969