Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartAce: Buttons block not responding to global color palette changes #8566

Closed
alaczek opened this issue Jan 8, 2025 · 4 comments
Closed
Assignees
Labels
[Pri] Normal [Type] Bug Something isn't working

Comments

@alaczek
Copy link
Contributor

alaczek commented Jan 8, 2025

When you update the color palette in global styles it doesn't affect the buttons block. This is because buttons block has it’s own color palette definition in theme.json, starting at line 4, that should be removed.

Global color palette:
Image

Color palette available while editing the button block:
Image

I think this is related to #7620

@alaczek alaczek added [Pri] Normal [Type] Bug Something isn't working labels Jan 8, 2025
@alaczek alaczek self-assigned this Jan 8, 2025
@davewhitley
Copy link

Might be related, it seems impossible (without css) to change the color of this button in a form block, even though I have defined the color as red, it shows up blue (front end and in the editor).

In the style book, all buttons in the Form block appear red.

Image

@davewhitley
Copy link

davewhitley commented Jan 14, 2025

Another issue that I hope is related: it appears that when I set a custom color background for any button, there appears to be no hover state. The hover state is removed?

Edit:

link elements that are styled to look like buttons have a hover state, but when you change the background color of the button, it is overriding the hover state. Because of this, I think it's impossible to set a different color for the hover state if you have already set the default background color?

I believe it's the same for button elements too.

@alaczek
Copy link
Contributor Author

alaczek commented Jan 17, 2025

@davewhitley this should be fixed now, including the contact form buttons (they should inherit from the theme and be consistent with other buttons).

As far as button hover color goes, the theme is using the secondary color for that - if you update it in the global color palette, it will filter through.

@alaczek alaczek closed this as completed Jan 20, 2025
@davewhitley
Copy link

In my example, the hover state is essentially disabled. When you change the background color of the button, it removes the hover state, and the color can't be changed (even if you change the color globally). I just tested this in 2025 though, and it does the same thing, so I'll keep this issue closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants