Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vows: fixes issues related to #8519 #8521

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Conversation

henriqueiamarino
Copy link
Collaborator

@henriqueiamarino henriqueiamarino commented Dec 13, 2024

This PR fixes the issues mentioned in #8519. I also updated outdated presets that CBT used to apply. Now, the theme follows the standards we apply to all new themes.

  • The missing fonts were added;
  • Style variations were fixed to call the correct fonts.

Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Vows.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

@alaczek alaczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me, except I don't see the Instrument Serif font used anywhere. If it's unused, please remove from the assets folder.

@henriqueiamarino
Copy link
Collaborator Author

henriqueiamarino commented Jan 13, 2025

Thanks for pointing this out, @alaczek. I just removed the unused fonts.

Copy link
Contributor

Theme-Check results

vows: No changes required ✅.


@henriqueiamarino henriqueiamarino merged commit 1119c02 into trunk Jan 15, 2025
3 checks passed
@henriqueiamarino henriqueiamarino deleted the update/vows-variations branch January 15, 2025 09:56
@henriqueiamarino
Copy link
Collaborator Author

@alaczek I merged it and tried to version bump it, but it didn't work. It's not the first time it has happened; I don't know what may be wrong with my setup. Can you please do it to me?

@iamtakashi
Copy link
Contributor

@henriqueiamarino It's probably that the theme with the fixes has already been deployed to Dotcom before you run the version bump workflow.

I manually bumped up the version here: #8614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants