-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vows: fixes issues related to #8519 #8521
Conversation
Preview changesI've detected changes to the following themes in this PR: Vows. I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me, except I don't see the Instrument Serif font used anywhere. If it's unused, please remove from the assets folder.
Thanks for pointing this out, @alaczek. I just removed the unused fonts. |
Theme-Check resultsvows: No changes required ✅. |
@alaczek I merged it and tried to version bump it, but it didn't work. It's not the first time it has happened; I don't know what may be wrong with my setup. Can you please do it to me? |
@henriqueiamarino It's probably that the theme with the fixes has already been deployed to Dotcom before you run the version bump workflow. I manually bumped up the version here: #8614 |
This PR fixes the issues mentioned in #8519. I also updated outdated presets that CBT used to apply. Now, the theme follows the standards we apply to all new themes.