Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DotCom Launch]: Brightblog #8505

Open
1 of 7 tasks
iamtakashi opened this issue Dec 6, 2024 · 1 comment
Open
1 of 7 tasks

[DotCom Launch]: Brightblog #8505

iamtakashi opened this issue Dec 6, 2024 · 1 comment
Assignees

Comments

@iamtakashi
Copy link
Contributor

iamtakashi commented Dec 6, 2024

DotCom launch checklist

  • Theme review
  • Create demo site
  • Create theme showcase
  • Network activate
  • Add theme to the curated list
  • Verify theme in showcase
  • Verify theme in onboarding
@iamtakashi iamtakashi self-assigned this Jan 15, 2025
@iamtakashi
Copy link
Contributor Author

@henriqueiamarino, here are my notes!

  • Add a no-results block with helpful text to the archives, blog home, index, and search results templates.
  • Can we reduce the side paddings on the main content area? It seems excessive for small screens, and it'd be great if it aligns with the header and the footer. This applies to the archives, 404, pages, search results, and posts templates.
    Image Image
  • For the blog home and the index templates, can we use a columns block instead of a row block? At the moment, the layout on small screens has room for improvement. Also, can we make the right-side padding for the content the same as the header? Image
  • The featured image feels like floating without an anchor. It would be nicer if they aligned at the top. Image
  • I'd recommend adding a comments section, at least in the single posts template.
  • Let's fix the value of size for the custom font size presets in the theme.json.
  • Remove parts/header.html and parts/header-pages.html.
  • A main tag is missing in the 404, pages, and single posts templates.
  • Let's add a title for each template part in the theme.json.
  • Remove patterns/about.php, patterns/comments.php, patterns/header-pages.php, and patterns/page.php.
  • Add 6.7 to Tested up to: in the readme.txt and style.css.
  • Add 7.2 to Requires PHP: in the readme.txt and style.css.
  • Remove the credit for Overused Grotesk.
  • Change the version number to use the semantic versioning 1.0.0 in style.css
  • Remove the following theme tags: entertainment, block-patterns, custom-background, custom-colors, custom-logo, editor-style, post-formats, template-editing, and theme-options.
  • Remove this duplicated comment in the style.css
/**
 * Currently table styles are only available with 'wp-block-styles' 
 * theme support (block css) thus the following needs to be included
 * since 'wp-block-styles' aren't used for this theme.
 * https://github.com/WordPress/gutenberg/issues/45065
 */
  • There are some instances of using numeric font size. In archives, home, index, search templates, and the post-meta pattern. Replace them with the small size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant