Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DotCom Launch]: MyMenu #8502

Open
1 of 7 tasks
iamtakashi opened this issue Dec 6, 2024 · 2 comments
Open
1 of 7 tasks

[DotCom Launch]: MyMenu #8502

iamtakashi opened this issue Dec 6, 2024 · 2 comments
Assignees

Comments

@iamtakashi
Copy link
Contributor

iamtakashi commented Dec 6, 2024

DotCom launch checklist

  • Theme review
  • Create demo site
  • Create theme showcase
  • Network activate
  • Add theme to the curated list
  • Verify theme in showcase
  • Verify theme in onboarding
@iamtakashi iamtakashi self-assigned this Jan 14, 2025
@iamtakashi
Copy link
Contributor Author

@henriqueiamarino Here are my notes. Not a lot to change, It's a solid theme.

  • Add the usual paragraph to the No Results block on the archives, index, and search results templates.
  • The font Fraunces isn't bundled, but it's not used anywhere. If it's no longer needed, let's get rid of it from the theme.json and readme.txt
  • Remove the-menu_sitelogo.png. It's not used in the theme.
  • parts/footer.html and parts/post-meta.html have text strings that should be internationalized. Resave the theme with the CBT (make sure the Process Only Modified Templates option is unticked.)
  • Let's list all three template parts in the theme.json with a title.
  • Let's remove unused patterns patterns/comments.php, patterns/header.php, patterns/gallery.php, patterns/post-list.php.
  • Change the Tested up to: to 6.7 in the readme.txt and style.css.
  • Change the Requires PHP: to 7.2 in the readme.txt and style.css.
  • Add an image credit for the logo since it's on the screenshot.png.
  • Remove block-patterns, custom-background, custom-colors, custom-header, custom-logo, custom-menu, editor-style, flexible-header, post-formats, theme-options, threaded-comments
  • Remove duplicate comment from style.css
/*
 * Control the hover stylings of outline block style.
 * Unnecessary once block styles are configurable via theme.json
 * https://github.com/WordPress/gutenberg/issues/42794
 */
  • There are two instances of 48px in the patterns/post-meta.php. Let's change it to use x-large.

@henriqueiamarino
Copy link
Collaborator

Thanks, @iamtakashi. The fixes are #8620.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants