Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lovecraft: Header image with empty alt attribute #8468

Open
mmtr opened this issue Nov 28, 2024 · 2 comments
Open

Lovecraft: Header image with empty alt attribute #8468

mmtr opened this issue Nov 28, 2024 · 2 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". [Pri] Low [Status] Auto-allocated [Status] Escalated to Product Ambassadors Triaged [Type] Bug Something isn't working

Comments

@mmtr
Copy link
Member

mmtr commented Nov 28, 2024

Reported in p1732711251970759-slack-C04DZ8M0GHW

Quick summary

The version of the Lovecraft theme that we maintain in wpcom does not support alt text in the header images: fbhepr%2Skers%2Sjcpbz%2Qcho%2Qgurzrf%2Sybirpensg%2Surnqre.cuc%3Se%3Q365r3p57-og

However, that's supported in the theme upstream: https://github.com/andersnoren/lovecraft/blob/eb47a204938efd43ade6d5605cfd0b048c28ac27/header.php#L162

We should port the alt text support to our version.

Steps to reproduce

  • Activate the Lovecraft theme
  • Go to Appearance > Customize
  • Select Header Image
  • Click on Add New Image
  • Select an image from the Media Library that has an Alt Text
  • Save the changes
  • Visit the frontend
  • Check the alt attribute of the header image

A clear and concise description of what you expected to happen.

The header image should use the Alt Text of the image as the alt attribute

What actually happened

The header image has an empty alt attribute

Impact

One

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

@radtechgh
Copy link

original issue: 9096856-zen

Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 9096856-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". label Nov 28, 2024
@vykes-mac vykes-mac assigned vykes-mac and unassigned vykes-mac Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". [Pri] Low [Status] Auto-allocated [Status] Escalated to Product Ambassadors Triaged [Type] Bug Something isn't working
Projects
Development

No branches or pull requests

4 participants