Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varia (and child themes): custom social menu is now outdated #8411

Open
jeherve opened this issue Nov 12, 2024 · 0 comments
Open

Varia (and child themes): custom social menu is now outdated #8411

jeherve opened this issue Nov 12, 2024 · 0 comments

Comments

@jeherve
Copy link
Member

jeherve commented Nov 12, 2024

Quick summary

The Varia theme (and consequently all its child themes) bundles its own version of Jetpack's Social Menu feature:
https://github.com/Automattic/themes/blob/trunk/varia/inc/icon-functions.php

This custom version works well, but doesn't include recent changes to Social Menus in Jetpack, like the inclusion of new social networks like Bluesky.

Steps to reproduce

  1. Start with a WordPress.com site where you've enabled the Varia theme or one of its child themes such as dalston.
  2. Go to Appearance > Customize > Menus
  3. Create a new menu and assign it to the social menu location.
  4. In that menu, create 2 custom links: https://x.com/automattic and https://bsky.app/profile/ma.tt
  5. Save your changes

A clear and concise description of what you expected to happen.

I expect both icons to appear in the social menu location:

Image

What actually happened

On the frontend, the Bluesky icon will not be displayed.

Image

Impact

All

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

Simple

Logs or notes

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant