Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byrne's charcoal style variation is broken #8383

Open
dsas opened this issue Nov 7, 2024 · 0 comments
Open

Byrne's charcoal style variation is broken #8383

dsas opened this issue Nov 7, 2024 · 0 comments

Comments

@dsas
Copy link
Contributor

dsas commented Nov 7, 2024

Quick summary

Applying the Charcoal style variation to the Byrne theme results in unreadable text.
Image

The style variation comes from the parent theme (blockbase) and is inherited by Byrne. We audited the theme and style variation in the past and decided that:

Byrne Charcoal - could potentially work with some adjustments to the homepage.

but we didn't do anything about that.

We should either make those adjustments, or exclude the charcoal variation from being offered with Byrne by adding the following to the settings key in the theme.json:

		"custom": {
			"excludedParentStyleVariations": [
				"Ruby Wine",
				"Charcoal"
			]
		},

Steps to reproduce

  1. Go to https://wordpress.com/theme/byrne
  2. Click on the second style variation (charcoal)

A clear and concise description of what you expected to happen.

I expected the preview on the right to change to a charcoaly (dark?) set of colours with readable text.

What actually happened

The background of most of the page changed to be a light colour on a near black background, except for the "Featured" bit at the top of the page, which used white text on a near white background.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

Don't choose the obviously broken style variation

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant