Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byrne looks broken in the site editor #8379

Open
dsas opened this issue Nov 7, 2024 · 4 comments
Open

Byrne looks broken in the site editor #8379

dsas opened this issue Nov 7, 2024 · 4 comments
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. Needs triage [Pri] Low [Theme] Byrne [Type] Bug Something isn't working

Comments

@dsas
Copy link
Contributor

dsas commented Nov 7, 2024

Quick summary

The Byrne demo and front-end site, doesn't match what you see in the site-editor, which looks rather broken.

Demo site Site editor Front-end
Image Image Image

Steps to reproduce

  1. Go to wordpress.com/theme/byrne
  2. Look at the theme preview, click on it to make it bigger if it helps
  3. Close the preview, if you opened it
  4. Activate the theme on a site
  5. Click 'Customize Site'

A clear and concise description of what you expected to happen.

I expected the site editor view to look like the theme demo

What actually happened

The site editor view looked really narrow and broken. Visiting the site looked like the theme demo though.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

  • Accept the site editor view looks odd.
  • Set a high content width in the global styles layout (haven't checked what the impact of this is)

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

@alaczek
Copy link
Contributor

alaczek commented Nov 13, 2024

This is likely the case for many Blockbase child themes (I checked Payton, Arbutus, Russell - all have it).
If we delisted these themes (which I think we should do sooner than later), do you think we would still fix it?

@dsas
Copy link
Contributor Author

dsas commented Nov 13, 2024

I think that's fine, the people who already have the themes are presumably ok with the weirdness and we won't be exposing new people to it.

There's also some issues open about blockbase children and the blockbase style variations, so possibly we could close those too, or at least they become even less urgent 🤔

I think these are all of the blockbase children:

  • ames
  • antonia
  • appleton
  • arbutus
  • attar
  • barnett
  • bennett
  • blank-canvas-blocks
  • blockbase
  • calvin
  • dorna
  • farrow
  • geologist-blue
  • geologist-cream
  • geologist-slate
  • geologist-yellow
  • geologist
  • hari
  • heiwa
  • jackson
  • kingsley
  • marl
  • mayland-blocks
  • meraki
  • quadrat-black
  • quadrat-green
  • quadrat-red
  • quadrat-white
  • quadrat-yellow
  • quadrat
  • russell
  • seedlet-blocks
  • varese
  • videomaker
  • winkel
  • zoologist

Looking at the theme trends Marl was the fourth most popular onboarding theme (9th most popular in LITS) and it looks like it's been consistently up there over the last few months. Russel was 15th. None of the others were top twenty.

@alaczek
Copy link
Contributor

alaczek commented Nov 14, 2024

Looking at the theme trends Marl was the fourth most popular onboarding theme

Do you mean that we should fix Marl and Russell anyway because they are very popular?

Marl is so popular because it's one of two free themes in the Store category. I recently launched Aether, and will be launching Batch shortly to replace Marl and Attar, which I plan to delist.

@dsas
Copy link
Contributor Author

dsas commented Nov 14, 2024

Just raising awareness that they're popular so we should be careful, sounds like you already know and have a plan though, so it seems fine to go ahead with delisting 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. Needs triage [Pri] Low [Theme] Byrne [Type] Bug Something isn't working
Projects
Development

No branches or pull requests

2 participants