Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spiel theme: Changing link color on first Query Loop block included in Front Page template doesn't hold #8378

Open
tanjoymor opened this issue Nov 7, 2024 · 2 comments

Comments

@tanjoymor
Copy link

Quick summary

Specifically on the first Query Loop block that is included in the Front Page template of the Spiel theme, changing the Link color doesn't hold after you refresh, for either the Title block or the Categories block. This seems to be a very specific issue to the design and this one particular instance of the Query Loop block.

Steps to reproduce

  1. On any Dotcom site (Simple or Atomic) activate the Spiel theme
  2. Open the Site Editor to the Front Page template
  3. Select the Title block in the first Query Loop (the larger one on the left)
  4. Make sure that the "Make title a link" toggle is on
  5. Change the Link Default Color
  6. Save
  7. Refresh
  8. Repeat for the Categories block (same thing happens)
  9. The Excerpt link works as expected

A clear and concise description of what you expected to happen.

I expected the color I switched to to remain as the active applied color.

What actually happened

The color reverts back to the default color.

CleanShot.2024-11-06.at.16.48.57.mp4

Impact

Some (< 50%)

Available workarounds?

Yes, difficult to implement

If the above answer is "Yes...", outline the workaround.

I have not tried creating a custom CSS class to see if CSS could override this.

Delete the included Query Loop and add a new one, the new instance works as expected (but is no easy feat for many users to reconfigure properly).

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

No response

@alaczek
Copy link
Contributor

alaczek commented Nov 13, 2024

I can replicate. The site title and categories link color is set via theme.json, and weirdly, cannot be reset via the editor :| It also cannot be overriden on the block level.

Image

I fond a Gutenberg issue that seems to cover this case: WordPress/gutenberg#66148

@alaczek
Copy link
Contributor

alaczek commented Nov 13, 2024

Ok, I think I might have been wrong there - I tested this with TT4 by adding the styles for Title block to the theme.json file, but I was still able to override them on the block level.

I believe the issue stems from the fact that there are block level styles applied to the title and terms block. Removing them doesn't impact the default appearance, but allows changing the colors. I will have a fix for this shortly.

alaczek added a commit that referenced this issue Nov 13, 2024
Remove the text and link color props from the blocks so that they can properly inherit colors and allow for making chnages. Fixes #8378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants