Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epi: WooCommerce templates showing by default in Site Editor without Woo ever being activated #8280

Open
philnick206 opened this issue Oct 16, 2024 · 5 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] Normal Triaged [Type] Bug Something isn't working

Comments

@philnick206
Copy link

Quick summary

After activating the Epi theme on a simple site the default Woo templates will be included in the Site Editor like Cart, Checkout, Single Product, etc.

Image

Steps to reproduce

  1. On a simple site, activate Epi theme
  2. Go to Appearance > Editor > Templates

A clear and concise description of what you expected to happen.

No Woo templates should be present

What actually happened

Woo templates are present

Impact

All

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

Ignore the templates

Platform (Simple and/or Atomic)

No response

Logs or notes

Reported in 8872228-zd-a8c

Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 8872228-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". label Oct 16, 2024
@Robertght
Copy link

📌 REPRODUCTION RESULTS

  • Tested on Atomic – Replicated

📌 ACTIONS

  • Triaged
  • I couldn't replicate this with TT4 or Mann.

@Robertght Robertght changed the title Epi Theme: WooCommerce templates showing by default in Site Editor without Woo ever being activated Epi: WooCommerce templates showing by default in Site Editor without Woo ever being activated Oct 23, 2024
@matticbot matticbot moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Oct 23, 2024
@alaczek
Copy link
Contributor

alaczek commented Nov 13, 2024

@philnick206 I went through the customer interaction and I'm not seeing them having an issue with these templates. Can you help me understand why this is a problem that these templates exist in the themes?

@iamtakashi are the woo templates included in this theme on purpose?

@philnick206
Copy link
Author

@alaczek You are correct that the user didn't call out these templates specifically, but if I remember correctly, when looking at the site, they had gone in and edited the Product template at some point (who knows why, I think they thought those were the same as pages), and I noticed it was showing an error because Woo wasn't installed. I think that, generally speaking, having any of those Woo templates there when Woo isn't activated looks bad (since they are broken) and can lead to unnecessary confusion. Thus, I opened this bug.

@iamtakashi
Copy link
Contributor

@iamtakashi are the woo templates included in this theme on purpose?

Yeah, this is in an awkward situation now. The base theme, Archivo was built a couple of years ago when there was nothing coming out from Woo regarding templates/themes. I remember that Woo didn't provide templates, and having those templates was the only way to support Woo in working in a less broken way.

I'm more than happy to remove all the templates from the related themes, Archivo, Epi, Kaze, and Pomme, but I'm not sure what would happen to the sites using Woo. Will removing those templates now break those sites? Can anyone from Woo chime in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] Normal Triaged [Type] Bug Something isn't working
Projects
Development

No branches or pull requests

4 participants