Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creatio Theme does not accept custom fonts #8044

Open
sbathompson-he opened this issue Aug 27, 2024 · 4 comments
Open

Creatio Theme does not accept custom fonts #8044

sbathompson-he opened this issue Aug 27, 2024 · 4 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". [Feature Group] Appearance & Themes Features related to the appearance of sites. Groundskeeping Worked on by Dotcom Groundskeeping [Pri] Normal [Status] Needs Author Reply [Theme] Creatio [Type] Bug Something isn't working

Comments

@sbathompson-he
Copy link

Quick summary

The Creatio theme does not allow users to use custom fonts. When a user changes the font from default, certain blocks break and cannot be recovered unless a page refresh is done. I tested this on a test site and found the same issue, so it must be tied to the theme.
I also noticed, that when the Global Style font is changed, it does not change the already affected blocks. The font remains.

Steps to reproduce

  1. Select Creatio as the sites theme
  2. In Global Styles, or in any block, change the font to something else. I tried Libre, and a couple others
  3. The blocks will break and cannot be edited on the homepage

What you expected to happen

Shouldn't break and should remain editable

What actually happened

Screen.Recording.2024-08-22.at.12.50.35.PM.mov

Impact

Most (> 50%)

Available workarounds?

Yes, difficult to implement

If the above answer is "Yes...", outline the workaround.

Create new blocks and paste in the content using the default font

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

@sbathompson-he sbathompson-he added [Type] Bug Something isn't working [Feature Group] Appearance & Themes Features related to the appearance of sites. Needs triage labels Aug 27, 2024
@mrfoxtalbot
Copy link

Thank you for reporting this @sbathompson-he.

I was unable to replicate it following these steps:

  1. Set a custom font
  2. Try to edit existing paragraphs and headings in a page

Are you still able to replicate this?
Can you confirm this is indeed Creatio? The video looks somewhat different.
Could you please share a link to the site in question? I'd like to take a direct look.

Thank you!

@Copons
Copy link
Contributor

Copons commented Sep 3, 2024

I can reproduce the issue, but only on the reported site.
The site does use the Creatio theme, however I don't think it's a Creatio issue.

Rather, it seems to be a Jetpack Google Fonts issue or directly related to how we handle fonts on Dotcom.

The error is triggered by this line from Gutenberg, which expects the fontFamilyFaces variable as an array.

All my own test sites return an array like this:

[
  {
    fontFamily: "Cormorant",
    fontStyle: "normal",
    fontWeight: "300",
    src: "https://fonts.wp.com/s/cormorant/v21/H4c2BXOCl9bbnla_nHIA47NMUjsNbCVrFk9TQ7Fg7A2uwYs.woff2",
  },
  // ...
]

On the reported site, however, the variable is an object (and in a very different format):

{
  "libre-baskerville-100-900-italic": {
    fontDisplay: "fallback",
    fontFamily: "Libre Baskerville",
    fontStyle: "italic",
    fontWeight: "100 900",
    origin: "gutenberg_wp_fonts_api",
    provider: "jetpack-google-fonts",
  },
  // ...
}

I'm not familiar with how we handle external fonts, and I know it's a very complex affair.
I'll ping @arthur791004, who might direct us to the right people. 🙂

@Copons Copons added the Groundskeeping Worked on by Dotcom Groundskeeping label Sep 4, 2024
@chekle
Copy link

chekle commented Jan 22, 2025

Hey team!

The user followed up here: 9316294-zd-a8c and mentioned that they are still experiencing this issue. It looks like this one is a work in progress, but I just wanted to send an update. Thank you

Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 9316294-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". [Feature Group] Appearance & Themes Features related to the appearance of sites. Groundskeeping Worked on by Dotcom Groundskeeping [Pri] Normal [Status] Needs Author Reply [Theme] Creatio [Type] Bug Something isn't working
Projects
Development

No branches or pull requests

4 participants