Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repeated word rule doesn't fire #253

Open
notuntoward opened this issue Oct 29, 2024 · 6 comments
Open

repeated word rule doesn't fire #253

notuntoward opened this issue Oct 29, 2024 · 6 comments
Assignees

Comments

@notuntoward
Copy link

Repeated words aren't detected, although I have this rule turned on. Below, "accurate" is repeated.

image

image

@grantlemons
Copy link
Collaborator

grantlemons commented Nov 12, 2024

Currently, our implementation only considers certain commonly repeated words for this lint. I can try to reimplement this such that it will check all words, but a more immediate step that should be taken is updating the description for the setting to make it clear that it only considers commonly repeated words.

Currently checked words:

"the", "be", "to", "of", "and", "a", "in", "that", "have", "I", "it", "for", "not",
"on", "with", "he", "as", "you", "do", "at", "this", "is", "but", "his", "by", "from",
"they", "we", "say", "her", "she", "or", "an", "will", "my", "one", "all", "would",
"there", "their", "what", "so", "up", "out", "if", "about", "who", "get", "which",
"go", "me", "when", "make", "can", "like", "time", "no", "just", "him", "know", "take",
"people", "into", "year", "your", "good", "some", "could", "them", "see", "other",
"than", "then", "now", "look", "only", "come", "its", "over", "think", "also", "back",
"after", "use", "two", "how", "our", "work", "first", "well", "way", "even", "new",
"want", "because", "any", "these", "give", "day", "most", "us", "are",

@elijah-potter
Copy link
Collaborator

Hey @notuntoward,

Sorry for the delay in getting back to you on this. Things have been a little hectic.

We've just released Harper v0.13.0, which incorporates some significant improvements to this rule, thanks to @grantlemons.
Would you mind testing to make sure you don't get any more false-negatives like this so we can close issue?

@notuntoward
Copy link
Author

@elijah-potter , Thanks. Unfortunately, it still doesn't work for me in this example:

this paper shows that, while the method may be more accurate accurate, the turnout overestimate suggests that self-selection bias is not sufficiently reduced.

"accurate" is typed twice but the repetition isn't detected.

But I should note that I had difficulties updating -- the install procedure stalled on Harper. When I restarted obsidian, then I got a message saying something like "Harper cannot be restarted," After uninstall and then reinstall, Harper did restart, and appeared to be the newest version (1.3.0). But maybe it's not, really?

@grantlemons
Copy link
Collaborator

Ah, the obsidian plugin seemed to have had a large problem on 0.13.0 (#338), but @elijah-potter has pushed out 0.14.0 which should hopefully resolve the issue.

In my local tests I found that harper linted your example correctly, so if you update the obsidian plugin to the 0.14.0 version, it will probably work as intended.

@elijah-potter
Copy link
Collaborator

@notuntoward, would you mind confirming that the issue has been fixed on your end so we can close it out? Thanks again for letting us know about it!

@notuntoward
Copy link
Author

With 0.15.0, it still doesn't detect the repeat. This is on Obsidian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants