Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shore should setup a validated API contract between the CLI and Renderer #58

Open
eyal-mor opened this issue Feb 27, 2023 · 0 comments
Open

Shore should setup a validated API contract between the CLI and Renderer #58

eyal-mor opened this issue Feb 27, 2023 · 0 comments
Labels
bug Something isn't working DevX Developer Experience related good first issue Good for newcomers Renderer-JSONNET The issue is related to the built-in Jsonnet Renderer Shore-CLI Related to the Shore-CLI visualization layer (the CLI itself)

Comments

@eyal-mor
Copy link
Contributor

Currently missing parameters are not easily testable.
During manifestation of JSonnet, params are read from Render.yaml and passed to the render.

Missing parameters aren't debuggable due to the amount of abstraction introduced by Shore.

The error produced when running with an empty empty render.yml file:

ERRO[0000] Renderer.Render returned an error RUNTIME ERROR: Field does not exist: application
	/Users/liberms/code/platform/testshore/main.pipeline.jsonnet:5:20-38	object <anonymous>
	During manifestation
RUNTIME ERROR: Field does not exist: application
	/Users/liberms/code/platform/testshore/main.pipeline.jsonnet:5:20-38	object <anonymous>
	During manifestation
@dkirillov dkirillov added bug Something isn't working good first issue Good for newcomers DevX Developer Experience related Shore-CLI Related to the Shore-CLI visualization layer (the CLI itself) Renderer-JSONNET The issue is related to the built-in Jsonnet Renderer labels May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working DevX Developer Experience related good first issue Good for newcomers Renderer-JSONNET The issue is related to the built-in Jsonnet Renderer Shore-CLI Related to the Shore-CLI visualization layer (the CLI itself)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkirillov @eyal-mor