Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow negative offset #865

Open
IshanArya opened this issue Aug 2, 2024 · 2 comments
Open

Allow negative offset #865

IshanArya opened this issue Aug 2, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@IshanArya
Copy link

Describe the enhancement or feature you'd like

Allow negative offset to trigger dark mode before sunset. This would be a nice feature to have since, depending on location, it can get darker before sunset.

Currently, positive offsets are allowed, but not negative offsets.

@IshanArya IshanArya added the enhancement New feature or request label Aug 2, 2024
@Spiritreader
Copy link
Member

Spiritreader commented Nov 24, 2024

We should have negative offsets for geographic coordinates mode, but NOT if the windows night light mode is used.

Looks like this is a bug that's leftover from implementing offset for Windows night light, where it is indeed impossible to use negative offsets because we'd be able to be fortune tellers.
If "Follow windows night light" is selected, Auto Dark Mode is listening to the night light trigger event. Since it's an event, we can't react to the event before it exists.

However it should work for the geo modes.
I'll look into restoring functionality for geo mode.

@Spiritreader Spiritreader added bug Something isn't working and removed enhancement New feature or request labels Nov 24, 2024
@Spiritreader
Copy link
Member

Hmm, I am able to set negative offsets.

Screen.Recording.2024-11-25.002607.mp4

Is the offset not getting applied once you've correctly set it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants