Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong initialization of free-field/diffuse-field EQ #16

Open
oholiba opened this issue Jul 17, 2023 · 1 comment
Open

Wrong initialization of free-field/diffuse-field EQ #16

oholiba opened this issue Jul 17, 2023 · 1 comment

Comments

@oholiba
Copy link

oholiba commented Jul 17, 2023

In PluginProcessor.cpp, in lines 289, 293, and 297 different impulse responses are loaded into the same convolution unit "dfEqOmniConv". To fix this bug, the units "dfEqEightConv" (line 289), "ffEqOmniConv" (line 293) and "ffEqEightConv" (line 297) should be loaded with their appropriate impulse responses.

The bug was confirmed by testing the plugin in Reaper: the free field EQ has no effect on the processed audio.

This bug was introduced in the update to JUCE 6 (commit 48ca6cd).
@oholiba oholiba mentioned this issue Jul 17, 2023
Merged
@seclorum
Copy link
Contributor

Good catch, it would definitely be a necessary fix for next release ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seclorum @oholiba