Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send shutter "keep open" commands from pocs states #565

Open
fergusL opened this issue Aug 10, 2022 · 0 comments
Open

send shutter "keep open" commands from pocs states #565

fergusL opened this issue Aug 10, 2022 · 0 comments

Comments

@fergusL
Copy link
Contributor

fergusL commented Aug 10, 2022

At the moment the watchdog "keep open" commands are sent to the Musca shutter controller via a thread spawned in the init of the dome/shutter class. @AnthonyHorton has suggested it would be more robust to issue these commands from within a POCS state as then there will be no issues with lingering threads after POCS fails/shuts down.

The keep dome open command is issued here as part of the _async_dome_loop method that is run in the _dome_thread spawned here

Some additional things to consider pointed out by @AnthonyHorton:
"Might be a problem if taking long exposures though, longer than the watchdog timer period on Musca."

@fergusL fergusL changed the title Issue shutter "keep open" commands from pocs states send shutter "keep open" commands from pocs states Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant