Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use yaml file for AutomationHAT GPIO pin number assignment #22

Open
lspitler opened this issue Aug 5, 2019 · 5 comments
Open

use yaml file for AutomationHAT GPIO pin number assignment #22

lspitler opened this issue Aug 5, 2019 · 5 comments

Comments

@lspitler
Copy link
Member

lspitler commented Aug 5, 2019

To change the GPIO pin assignments currently one has to hack the __init__ function of:
https://github.com/AstroHuntsman/huntsman-dome/blob/develop/domehunter/__init__.py

Better to specify a yaml file that contains GPIO pin assignments.

Optional: see this file for how to implement GPIO pin assignments as a separate class:
https://github.com/panoptes/POCS/blob/develop/pocs/dome/astrohaven.py

@lspitler lspitler mentioned this issue Aug 5, 2019
@AnthonyHorton
Copy link
Member

@wtgee might encourage us to use the config server from panoptes-utils for this: https://github.com/panoptes/panoptes-utils/tree/develop/panoptes/utils/config

@wtgee
Copy link
Contributor

wtgee commented Aug 13, 2019 via email

@lspitler
Copy link
Member Author

Interesting idea. Normally for such a simple subsystem, I'd say its overkill, but it is an elegant solution in terms of long-term maintainability. I gather we'd be running a server for the Lens Pis anyways?

@wtgee I guess you must know you're well past the point where it must be tempting to fork off e.g. config-server (and a lot of your other utils) as its own repo (pyamlserver?) so someone doesn't need to install all of POCs to use this handy util.

@wtgee
Copy link
Contributor

wtgee commented Aug 13, 2019 via email

@fergusL
Copy link
Contributor

fergusL commented Sep 27, 2019

Should also read in calibrated az_to_ticks from yaml file instead of triggering a calibration run when gotoaz() is called and dome_az is None.
see original comment from @AnthonyHorton
#26 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants