Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Color" and "Color Mode" properties in the property animation api #6

Open
ArthurCose opened this issue Jul 11, 2022 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@ArthurCose
Copy link
Owner

ArthurCose commented Jul 11, 2022

-- should support this for consistency
{
  property = "Color",
  value = { r = 0xAA, g = 0xBB, b = 0xCC, a = 0x00 }
}

-- alpha is optional
{
  property = "Color",
  value = { r = 0xAA, g = 0xBB, b = 0xCC }
}

-- optional direct number mode, it's inconsistent with the rest of the api, but might be worth implementing everywhere else
{
  property = "Color",
  value = 0xAABBCC00
}

A color mode would be necessary, might need similar interpolation rules as animation states. (floor)

{
  property = "Color Mode",
  value = "Multiply"
}

{
  property = "Color Mode",
  value = "Add"
}

Would need to store these values on actors and send them to joining players so everyone has a consistent final state.

@ArthurCose ArthurCose added the enhancement New feature or request label Jul 11, 2022
@ArthurCose
Copy link
Owner Author

Not sure if we want a separate function for directly manipulating these values without animating / interpolation. Scaling and rotation of actions don't have a dedicated function either.

@TheMaverickProgrammer
Copy link
Contributor

interpolating and other math libs sounds like a community contributed library to me. Not something we need to concern ourselves with in the server.

@ArthurCose
Copy link
Owner Author

Interpolation would be necessary within the client (and sent as a packet from the server), invincibility has an animated interpolating color effect. Handling it through a server library would require a packet sent every frame and may appear choppy from dropped / late packets.

@TheMaverickProgrammer
Copy link
Contributor

Ah good point. I'll make a note on the client todos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants