-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
similarity matching edge cases - same artwork across multiple institutions #21
Comments
"I think that the way to resolve this is to update the insert query for the "Same" button to ensure that one of the Pharos URI's has not been marked as deprecated, and if it has, then to link to the new canonical URI, which may not be one of the two artworks that the user is reviewing" Yes, this will work and is easily imlememented. "I think we should run some tests and find cases where a single artwork has multiple matchings across institutions, and then test our these edge cases." |
I was going through the updated pages and had some thoughts on the way we create sameAs links through the matching process, and I wanted to share them here before I forget. I just want to make sure we are able to account for edge cases where there is a greater level of complexity to the matching process.
The scenario I was thinking about was related to our conversation about choosing which Pharos URI would be deprecated after creating a match. While the choice is less relevant when we only have one match between two artworks, the situation becomes more complex when we have multiple pairs of artworks that match across institutions.
In our similarity model let's say we have the following:
In a scenario where there is a match between Artworks local URI A, B, and C, where the artwork is X, a user first marks Artwork A + B as being the same. In this case, we have the following:
So far we are OK.
Next, the user reviews Artwork C with similarity data to Artwork B.
In this case, the model has no way to account for the change that has previously happened with the dropped link between the Pharos URI BB and local URI B. If the user marks these as being the same the following will happen according to our model:
OR
Either way what we really want is the following:
I think that the way to resolve this is to update the insert query for the "Same" button to ensure that one of the Pharos URI's has not been marked as deprecated, and if it has, then to link to the new canonical URI, which may not be one of the two artworks that the user is reviewing.
I think we should run some tests and find cases where a single artwork has multiple matchings across institutions, and then test our these edge cases.
The text was updated successfully, but these errors were encountered: