Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8: отказ от массива options #2

Open
KarelWintersky opened this issue Aug 19, 2024 · 3 comments
Open

PHP8: отказ от массива options #2

KarelWintersky opened this issue Aug 19, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@KarelWintersky
Copy link
Collaborator

Так как в PHP8 возможны именованные аргументы - мы можем отказаться от массива options в методе init

@KarelWintersky
Copy link
Collaborator Author

А в addScope нам надо добавить возможность задавать опции не только по индексу, но и ключу.

Сейчас:

AppLogger::addScope('mysql', 
[
    [ '__mysql.100-debug.log', Logger::DEBUG, 'enable' => true],
]);

а надо:

AppLogger::addScope('mysql', 
[
    [ 'file' => '__mysql.100-debug.log', 'level' => Logger::DEBUG, 'enable' => true],
]);

@KarelWintersky
Copy link
Collaborator Author

С бабблингом непонятно:
https://github.com/Seldaek/monolog/blob/main/doc/01-usage.md

@KarelWintersky
Copy link
Collaborator Author

Будет реализовано в 2.0, несовместимой с PHP 7.4

@KarelWintersky KarelWintersky self-assigned this Jan 21, 2025
@KarelWintersky KarelWintersky added the enhancement New feature or request label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant