Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observation augmentation doesn't work with HER #4

Open
Armandpl opened this issue Jun 6, 2022 · 0 comments
Open

Observation augmentation doesn't work with HER #4

Armandpl opened this issue Jun 6, 2022 · 0 comments

Comments

@Armandpl
Copy link
Owner

Armandpl commented Jun 6, 2022

starship-landing-gym/starship_landing_gym/envs/starship_env.py

Line 22 in 22d9c06

augment_obs=False, random_constants=False,

When editing the reward buffer we put the "achieved_goal" as the "desired_goal". But the augmented augmentations include the distance to the previous "desired_goal".
So it doesn't work. I should fix it/remove it.
@Armandpl Armandpl changed the title The augment obs args doesn't work with HER The observation augmentation doesn't work with HER Jun 6, 2022
@Armandpl Armandpl changed the title The observation augmentation doesn't work with HER Observation augmentation doesn't work with HER Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Armandpl