Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗺️ Haystask Instrumentation #524

Closed
18 tasks done
mikeldking opened this issue Jun 10, 2024 · 18 comments
Closed
18 tasks done

🗺️ Haystask Instrumentation #524

mikeldking opened this issue Jun 10, 2024 · 18 comments
Assignees
Labels
instrumentation Adding instrumentations to open source packages

Comments

@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Jun 10, 2024
@harrisonchu harrisonchu self-assigned this Jul 1, 2024
@harrisonchu harrisonchu added the instrumentation Adding instrumentations to open source packages label Jul 1, 2024
@mikeldking
Copy link
Contributor Author

Unknown span kinds show up for instrumentation
Screenshot 2024-08-07 at 1 41 16 PM

@mikeldking
Copy link
Contributor Author

Pipeline missing output
Screenshot 2024-08-07 at 2 17 02 PM

@mikeldking
Copy link
Contributor Author

LLM call doesn't match OTEL syntax for the name:
Screenshot 2024-08-07 at 2 17 42 PM

@mikeldking
Copy link
Contributor Author

Output messages is a string rather than a list of messages, causing pheonix to crash - this is using the quickstart
Screenshot 2024-08-07 at 2 18 54 PM

@Parker-Stafford
Copy link
Contributor

Parker-Stafford commented Aug 7, 2024

input to retriever is embedding - might want to opt for the query string if possible here? not sure what the best thing to do is here, running this tutorial https://haystack.deepset.ai/tutorials/27_first_rag_pipeline

image

@Parker-Stafford
Copy link
Contributor

Pipeline missing output Screenshot 2024-08-07 at 2 17 02 PM

also happening on this tutorial https://haystack.deepset.ai/tutorials/27_first_rag_pipeline

@Parker-Stafford
Copy link
Contributor

getting llmAttributes[LLMAttributePostfixes.output_messages]?.map is not a function this means we're expecting a list but getting something else when clicking on the llm span this tutorial:

https://haystack.deepset.ai/tutorials/27_first_rag_pipeline

image

@Parker-Stafford
Copy link
Contributor

this might be correct, not sure how haystack pipelines work but there is no hierarchy in the spans here, typically i feel like there is a little bit of nesting here

image

@Jgilhuly
Copy link

Jgilhuly commented Aug 7, 2024

Function / tool calling spans don't appear in Phoenix. Here's the trace for an invocation of the function calling tutorial at https://haystack.deepset.ai/tutorials/40_building_chat_application_with_function_calling

Screenshot 2024-08-07 at 1 38 03 PM

Need to add support for tool calling

@Parker-Stafford
Copy link
Contributor

not sure what the best solution is here but this might need some work, there are no prompt template variables in the prompt_template block of attributes, there are retrieval documents though which do seem to be passed in to the template.
I would expect to see {{question}} in the vars at least and maybe the documents

image

@mikeldking
Copy link
Contributor Author

Screenshot 2024-08-07 at 2 45 06 PM Haystack component run shows up as leaf nodes (looks like it's OTEL).

@cjunkin
Copy link
Contributor

cjunkin commented Aug 7, 2024

Screenshot 2024-08-07 at 1 46 22 PM
Screenshot 2024-08-07 at 1 46 31 PM

opening OpenAIGenerator span causes error

@cjunkin
Copy link
Contributor

cjunkin commented Aug 7, 2024

Screenshot 2024-08-07 at 1 47 54 PM
Screenshot 2024-08-07 at 1 48 50 PM

Not sure if this is the desired formatting

@axiomofjoy
Copy link
Contributor

axiomofjoy commented Aug 7, 2024

Screenshot 2024-08-07 at 1 45 56 PM

  • unknown span kinds
  • clicking through on OpenAIGenerator results in C.map is not a function error
  • missing outputs in spans
  • ConditionalRouter and SerpDevWebSearch have no attributes

@cjunkin
Copy link
Contributor

cjunkin commented Aug 7, 2024

Screenshot 2024-08-07 at 1 56 09 PM

Empty/null attributes

@mikeldking mikeldking moved this from 📘 Todo to 👨‍💻 In progress in phoenix Aug 12, 2024
@Parker-Stafford
Copy link
Contributor

Query is lost in final llm call when running this example : https://docs.haystack.deepset.ai/docs/lostinthemiddleranker#in-a-pipeline

image

Templating is a little off but this is a larger product / design issue see screen shot (no variables / template but variables and template in the Prompt template tab)

image

Small note this reranker doesn't require a query because it assumes the documents are already ordered by relevance and just takes those documents and places the most important (first) ones at the edges of the context - this makes the ui look a little weird with the empty query

image

@mikeldking
Copy link
Contributor Author

@axiomofjoy conda forge

@mikeldking
Copy link
Contributor Author

Only thing remaining is opentelemetry.io closing

@github-project-automation github-project-automation bot moved this from 👨‍💻 In progress to ✅ Done in phoenix Aug 29, 2024
@mikeldking mikeldking removed this from phoenix Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instrumentation Adding instrumentations to open source packages
Projects
Status: Done
Development

No branches or pull requests

7 participants