Skip to content
This repository has been archived by the owner on Feb 17, 2021. It is now read-only.

[Bugzilla 1265804] E10s: if location bar is not on nav bar, chromehidden windows fail to forward urls when opened through window.open() #192

Open
mreweilk opened this issue Apr 19, 2016 · 7 comments

Comments

@mreweilk
Copy link

mreweilk commented Apr 19, 2016

I like having the location bar show up in the menu bar to save space and I've noticed an issue when e10s is enabled.

When the location bar is placed in the menu bar it seems that popup windows do not work at all.

https://i.gundam.eu/1461044763.png
This is a fresh profile with only Classic Theme Restorer and the location bar moved to the menu bar.

https://i.gundam.eu/1461046230.png
When the location bar is not in the menu the problem does not occur.
If e10s is disabled the problem does not occur.

I am using FF 47.0a2 developer edition and Classic Theme Restorer 1.5.1beta7.

@Aris-t2
Copy link
Owner

Aris-t2 commented Apr 19, 2016

I'm not sure this can be fixed in CTR.

Using e10s Firefox fails to forward urls via window.open(), if the location bar is on a non-visible toolbar instead of being on main navigation toolbar.

CTR allows to move location bar to any toolbar, but windows which hide toolbars require it on navigation toolbar.

The only solution I could offer is a moving location bar to navigation toolbar once a window without toolbars opens. But this will also move the location bar back to its default toolbar on main window, which I guess is not a good solution at all.

This looks like a Firefox bug for me. I will report it on Bugzilla.
Filed a bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1265804

@mreweilk
Copy link
Author

Thanks for looking into it. Hopefully someone over at mozilla will look at it. I suppose I'll just have to disable e10s until something is changed.

@Aris-t2
Copy link
Owner

Aris-t2 commented Apr 20, 2016

For such sites to work you can either disable e10s or move the location bar back to navigation toolbar.

I'm not sure how or if Mozilla will handle this, but in the past they tried to get rid of browser features, which refused to work properly in e10s mode.

@Aris-t2 Aris-t2 changed the title Problem with e10s and the location bar in the menu bar. [Bug 1265804] E10s: if location bar is not on nav bar (via add-on), chromehidden windows fail to forward urls when opened through window.open() Apr 24, 2016
@Aris-t2 Aris-t2 changed the title [Bug 1265804] E10s: if location bar is not on nav bar (via add-on), chromehidden windows fail to forward urls when opened through window.open() [Bugzilla 1265804] E10s: if location bar is not on nav bar, chromehidden windows fail to forward urls when opened through window.open() Apr 24, 2016
@mreweilk
Copy link
Author

mreweilk commented Jun 4, 2016

Seems like they are ignoring the issue. :(

Maybe there is a way to sort of duplicate the url bar and have it also on the non-visible navigation bar to sort of mitigate this issue?

@Aris-t2
Copy link
Owner

Aris-t2 commented Jun 5, 2016

Unfortunately not. Too many internal listeners look and search for the "default" location bar and its contents (identity box, buttons, input box). CTR already offers a second location ar, but that one gets completely ignored by all default functions.

Since moving location bar is a non-default browser feature, they might never fix this problem.

@mreweilk
Copy link
Author

mreweilk commented Jun 5, 2016

I'd try and locate the bug myself but I wouldn't even know where to start looking.

@InternalError503
Copy link
Contributor

I ran into issue in the past with moving the navigation bar, 1172484 to many elements are bound, checking, listening or in some cases the entire browser can break if moved from its default position, Most issues of this nature are slapped with RESOLVED WONTFIX

I used to have a custom setting to allow the url-bar to be movable with warnings of potential breakage, This was removed in favor for @Aris-t2 cleaner implementation.

@mreweilk To fix this would require many patches to Firefox source with no guaranty of been able to be maintained due to the coming GUI changes with the removal of XUL, It would be allow of work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants