-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer pathlib to os.path in launch files #35
Comments
I can take this up. What would be the acceptance criteria for this issue? I have a Ubuntu 22.04/ROS Humble setup. |
Hello - if you are still interested, a pull request is surely welcome. Everwhere you see any call to As an example, see here: |
Hi @Ryanf55 , I have made the changes in all the launch files as you mentioned. Could you please let me know what logs should I be putting in the PR, does |
Yes, that sounds sufficient. I'll test the changes locally before merge too. |
Hi, I have put up a pr (#47) with changes following your instructions. Kindly review the same. |
Update launch files to consistently use
pathlib
rather thanos.path
.The text was updated successfully, but these errors were encountered: