Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer pathlib to os.path in launch files #35

Closed
srmainwaring opened this issue Oct 25, 2023 · 5 comments
Closed

Prefer pathlib to os.path in launch files #35

srmainwaring opened this issue Oct 25, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@srmainwaring
Copy link
Collaborator

Update launch files to consistently use pathlib rather than os.path.

@srmainwaring srmainwaring added the enhancement New feature or request label Oct 25, 2023
@Ryanf55 Ryanf55 added the good first issue Good for newcomers label Oct 27, 2023
@SrijaneeBiswas
Copy link

I can take this up. What would be the acceptance criteria for this issue?

I have a Ubuntu 22.04/ROS Humble setup.

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Jan 21, 2024

Hello - if you are still interested, a pull request is surely welcome.

Everwhere you see any call to os.path, replace it with pathlib.Path equivalent.
Then, test all the modified files. If you can, put some screenshots or logs in the PR to demonstrate it.
Finally, submit the PR.

As an example, see here:
ethz-asl/grid_map_geo#56

@pulak-gautam
Copy link
Contributor

Hi @Ryanf55 , I have made the changes in all the launch files as you mentioned. Could you please let me know what logs should I be putting in the PR, does launch.log with verbosity to INFO suffice?

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Jan 24, 2024

Yes, that sounds sufficient. I'll test the changes locally before merge too.

@pulak-gautam
Copy link
Contributor

Hi, I have put up a pr (#47) with changes following your instructions. Kindly review the same.
Thank you for your time.

@Ryanf55 Ryanf55 closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

4 participants