Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception during TryConnectAndLogin may be wrong. #96

Closed
Berserker66 opened this issue Jul 4, 2024 · 0 comments · Fixed by #97
Closed

Exception during TryConnectAndLogin may be wrong. #96

Berserker66 opened this issue Jul 4, 2024 · 0 comments · Fixed by #97

Comments

@Berserker66
Copy link
Member

Should an exception be raised during the method TryConnectAndLogin, such as if the Connected package coming from the server fails to parse (be it due to intentional destruction or #95), then the Exception that bubbles up out of the library is just a Timeout exception, which is confusing and wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Berserker66