From c4bf8c3a7df19e9f39919ddf172fc0a2bf57ef3d Mon Sep 17 00:00:00 2001 From: Sam Poe Date: Wed, 15 May 2019 10:53:10 -0400 Subject: [PATCH 1/5] Board Image Fix De-commented code to allow user pic on boards footer --- Innovator/Client/scripts/kanban/js/script.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Innovator/Client/scripts/kanban/js/script.js b/Innovator/Client/scripts/kanban/js/script.js index 163f8a7..1c342be 100644 --- a/Innovator/Client/scripts/kanban/js/script.js +++ b/Innovator/Client/scripts/kanban/js/script.js @@ -236,10 +236,10 @@ function loadBoards() { // get boardimage var vaultref = item.getProperty("creatorpicture","undefined"); var fileUrl = "nomanager.png"; - /*if ((vaultref !== "undefined") && (vaultRefTable[vaultref] == undefined)) { + if ((vaultref !== "undefined") && (vaultRefTable[vaultref] == undefined)) { fileUrl = inn.getFileUrl(vaultref.split("?fileId=")[1], 1); vaultRefTable[vaultref] = fileUrl; - }*/ + } boardsContentString += "

" + item.getProperty('boardname', 'no name') + "

" + item.getProperty('boarddescription', 'no description') + "
"; boardsContentString += "
" + nameInitiliser(item.getPropertyAttribute("created_by_id", "keyed_name")) + "
no manager
"; From 4f679b82ff3820b650e67b31c41de96bbdbb785c Mon Sep 17 00:00:00 2001 From: Sam Poe Date: Wed, 15 May 2019 10:56:31 -0400 Subject: [PATCH 2/5] Readme Updated - Updated History to table format. - Checked module against 11.0 SP12, 15 --- README.md | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index b01edc4..8ae6c41 100644 --- a/README.md +++ b/README.md @@ -3,13 +3,19 @@ Adds a user interface to manage tasks and sort them by Stage, Account, Risk ... #### How it works The Kanban-like-task-management project has two interfaces - the Board listing, and the Board details (when you enter a board by double-clicking on it). -## Project Details +## History -**Built Using:** Aras 11.0 SP7 +Release | Notes +--------|-------- +[v1.0.1](https://github.com/ArasLabs/kanban-like-task-management/releases/tag/v1.0.1) | Tested 11.0 SP12, SP15. Tested on Edge, IE, Firefox 60 ESR, Chrome. +[v1.0.0](https://github.com/ArasLabs/kanban-like-task-management/releases/tag/v1.0.0) | First release. Tested on Internet Explorer 11, Firefox 38 ESR, Chrome. -**Browsers Tested:** Internet Explorer 11, Firefox 38 ESR, Chrome +#### Supported Aras Versions -> Though built and tested using Aras 11.0 SP7, this project should function in older releases of Aras 11.0 and Aras 10.0. +Project | Aras +--------|------ +[v1.0.1](https://github.com/ArasLabs/kanban-like-task-management/releases/tag/v1.0.1) | 10.0 SPx, 11.0 SP7+, 11.0 SP12+, 11.0 SP15 +[v1.0.0](https://github.com/ArasLabs/kanban-like-task-management/releases/tag/v1.0.0) | 10.0 SPx, 11.0 SP7; Old Community Board Migration ## Installation From b2bd31a765fb6ecffc0e4bdc8b96601c6ee5f16b Mon Sep 17 00:00:00 2001 From: Sam Poe Date: Wed, 15 May 2019 14:16:00 -0400 Subject: [PATCH 3/5] Board Image Fix v2 - Added Try/Catch in case of malformatted user picture. - Corrected default image file path --- Innovator/Client/scripts/kanban/js/script.js | 27 ++++++++++++-------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/Innovator/Client/scripts/kanban/js/script.js b/Innovator/Client/scripts/kanban/js/script.js index 1c342be..68a445c 100644 --- a/Innovator/Client/scripts/kanban/js/script.js +++ b/Innovator/Client/scripts/kanban/js/script.js @@ -235,11 +235,17 @@ function loadBoards() { // get boardimage var vaultref = item.getProperty("creatorpicture","undefined"); - var fileUrl = "nomanager.png"; + var fileUrl = "../kanban/nomanager.png"; if ((vaultref !== "undefined") && (vaultRefTable[vaultref] == undefined)) { - fileUrl = inn.getFileUrl(vaultref.split("?fileId=")[1], 1); - vaultRefTable[vaultref] = fileUrl; + try{fileUrl = inn.getFileUrl(vaultref.split("?fileId=")[1], 1); + vaultRefTable[vaultref] = fileUrl; + } + catch(err){ + console.log("Profile Image for " + item.getPropertyAttribute("created_by_id", "keyed_name") + " is malformed. Please choose a different image."); + } + } + else{vaultRefTable[vaultref] = fileUrl;} boardsContentString += "

" + item.getProperty('boardname', 'no name') + "

" + item.getProperty('boarddescription', 'no description') + "
"; boardsContentString += "
" + nameInitiliser(item.getPropertyAttribute("created_by_id", "keyed_name")) + "
no manager
"; @@ -453,16 +459,17 @@ function loadSingleBoard(boardId, reload) { // get cardimage var vaultref = item.getProperty("managerpicture"); - var fileUrl = "nomanager.png"; + var fileUrl = "../kanban/nomanager.png"; if ((vaultref !== undefined) && (vaultRefTable[vaultref] == undefined)) { - if (inn.getFileUrl(vaultref.split("?fileId=")[1], 1) == undefined) { + try{fileUrl = inn.getFileUrl(vaultref.split("?fileId=")[1], 1); vaultRefTable[vaultref] = fileUrl; - } else { - vaultRefTable[vaultref] = inn.getFileUrl(vaultref.split("?fileId=")[1], 1); - } - } else if (vaultref == undefined) { - vaultRefTable[vaultref] = fileUrl; + } + catch(err){ + console.log("Profile Image for " + item.getPropertyAttribute("manager", "keyed_name") + " is malformed. Please choose a different image."); + } + } + else {vaultRefTable[vaultref] = fileUrl;} From 20d949b4e26eabbc9fb293ba050f6d2b14e9ec0c Mon Sep 17 00:00:00 2001 From: Sam Poe <46939101+sampoearas@users.noreply.github.com> Date: Thu, 25 Jul 2019 16:10:24 -0400 Subject: [PATCH 4/5] Resolved Issues Reformatted if-else, try-catch statements to be more visible --- Innovator/Client/scripts/kanban/js/script.js | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/Innovator/Client/scripts/kanban/js/script.js b/Innovator/Client/scripts/kanban/js/script.js index 68a445c..8a3bf0e 100644 --- a/Innovator/Client/scripts/kanban/js/script.js +++ b/Innovator/Client/scripts/kanban/js/script.js @@ -237,7 +237,8 @@ function loadBoards() { var vaultref = item.getProperty("creatorpicture","undefined"); var fileUrl = "../kanban/nomanager.png"; if ((vaultref !== "undefined") && (vaultRefTable[vaultref] == undefined)) { - try{fileUrl = inn.getFileUrl(vaultref.split("?fileId=")[1], 1); + try { + fileUrl = inn.getFileUrl(vaultref.split("?fileId=")[1], 1); vaultRefTable[vaultref] = fileUrl; } catch(err){ @@ -245,7 +246,9 @@ function loadBoards() { } } - else{vaultRefTable[vaultref] = fileUrl;} + else { + vaultRefTable[vaultref] = fileUrl; + } boardsContentString += "

" + item.getProperty('boardname', 'no name') + "

" + item.getProperty('boarddescription', 'no description') + "
"; boardsContentString += "
" + nameInitiliser(item.getPropertyAttribute("created_by_id", "keyed_name")) + "
no manager
"; @@ -461,7 +464,8 @@ function loadSingleBoard(boardId, reload) { var vaultref = item.getProperty("managerpicture"); var fileUrl = "../kanban/nomanager.png"; if ((vaultref !== undefined) && (vaultRefTable[vaultref] == undefined)) { - try{fileUrl = inn.getFileUrl(vaultref.split("?fileId=")[1], 1); + try{ + fileUrl = inn.getFileUrl(vaultref.split("?fileId=")[1], 1); vaultRefTable[vaultref] = fileUrl; } catch(err){ @@ -469,7 +473,9 @@ function loadSingleBoard(boardId, reload) { } } - else {vaultRefTable[vaultref] = fileUrl;} + else { + vaultRefTable[vaultref] = fileUrl; + } From 18955e765aac146f2f68be7808059daffa09033b Mon Sep 17 00:00:00 2001 From: Sam Poe <46939101+sampoearas@users.noreply.github.com> Date: Thu, 25 Jul 2019 16:27:33 -0400 Subject: [PATCH 5/5] Apply suggestions from code review Co-Authored-By: Eli J. Donahue --- Innovator/Client/scripts/kanban/js/script.js | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/Innovator/Client/scripts/kanban/js/script.js b/Innovator/Client/scripts/kanban/js/script.js index 8a3bf0e..886b6cf 100644 --- a/Innovator/Client/scripts/kanban/js/script.js +++ b/Innovator/Client/scripts/kanban/js/script.js @@ -240,13 +240,11 @@ function loadBoards() { try { fileUrl = inn.getFileUrl(vaultref.split("?fileId=")[1], 1); vaultRefTable[vaultref] = fileUrl; - } - catch(err){ + } catch(err) { console.log("Profile Image for " + item.getPropertyAttribute("created_by_id", "keyed_name") + " is malformed. Please choose a different image."); } - } - else { + } else { vaultRefTable[vaultref] = fileUrl; } @@ -464,16 +462,14 @@ function loadSingleBoard(boardId, reload) { var vaultref = item.getProperty("managerpicture"); var fileUrl = "../kanban/nomanager.png"; if ((vaultref !== undefined) && (vaultRefTable[vaultref] == undefined)) { - try{ + try { fileUrl = inn.getFileUrl(vaultref.split("?fileId=")[1], 1); vaultRefTable[vaultref] = fileUrl; - } - catch(err){ + } catch (err) { console.log("Profile Image for " + item.getPropertyAttribute("manager", "keyed_name") + " is malformed. Please choose a different image."); } - } - else { + } else { vaultRefTable[vaultref] = fileUrl; }