Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long texts in string settings #15

Open
sebaslavigne opened this issue May 1, 2020 · 2 comments
Open

Long texts in string settings #15

sebaslavigne opened this issue May 1, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@sebaslavigne
Copy link

When using very long texts in the settings they overflow the text box. The text editing dialog also presents some glitches, and when trying to select the whole text the game throws:

System.ArgumentOutOfRangeException: 'Length cannot be less than zero.
Parameter name: length'

The example images are settings containing banner codes generated with the online banner editor

Images

image

image

@Aragas Aragas added the bug Something isn't working label May 6, 2020
@Aragas
Copy link
Owner

Aragas commented May 6, 2020

Can't say it's expected that the game would handle this, but adding length checks in MCM would be a good thing anyway. Thanks for reporting!

@Aragas
Copy link
Owner

Aragas commented Jun 22, 2020

This concrete error, if I remember right, is caused by some strange condition
Basically, it will trigger when casually using the edit dialog and randomly selecting text.
The game's logic is causing this. I added a simple workaround that ignores the exception. Further investigation is needed

@Aragas Aragas self-assigned this Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants