Skip to content
This repository has been archived by the owner on Oct 3, 2020. It is now read-only.

Generate RPM in addition to DEB #26

Closed
probonopd opened this issue Nov 11, 2018 · 10 comments
Closed

Generate RPM in addition to DEB #26

probonopd opened this issue Nov 11, 2018 · 10 comments
Labels
enhancement New feature or request help-wanted Extra attention is needed

Comments

@probonopd
Copy link
Member

probonopd commented Nov 11, 2018

Continuation of #6 (comment)

@probonopd probonopd added enhancement New feature or request help-wanted Extra attention is needed labels Nov 11, 2018
@TheAssassin
Copy link
Member

Not entirely sure what you're doing on that other branch, but it's clearly not a fork of the master branch. It still contains a submodule on AppImageKit?!

@TheAssassin
Copy link
Member

You were almost there, it seems.

First of all, I ran git fetch --all && git rebase origin/master to update the branch.

Then, I noticed you didn't include the architecture fix snippet we use elsewhere. Since we build RPMs on a Debian system, we need to inform CPack about the right architecture. It doesn't seem very straightforward, but it seems that if that architecture is set to an invalid or empty value, a source package will be built.

# allow building RPM packages on non-RPM systems
if(DEFINED ENV{ARCH})
    set(CPACK_RPM_PACKAGE_ARCHITECTURE $ENV{ARCH})
    if(CPACK_RPM_PACKAGE_ARCHITECTURE MATCHES "i686")
        set(CPACK_RPM_PACKAGE_ARCHITECTURE "i386")
    elseif(CPACK_RPM_PACKAGE_ARCHITECTURE MATCHES "amd64")
        set(CPACK_RPM_PACKAGE_ARCHITECTURE "x86_64")
    endif()
endif()

Then, I moved the include(CPack) at the end of both cmake/cpack_{rpms,debs}.cmake files into the main CMake file (below the two include()s), as CPack doesn't like to be included more than once (there's a warning in the output, we had the same issue in AppImageLauncher).

If you want to, I can force-push to your branch.

@probonopd
Copy link
Member Author

If you want to, I can force-push to your branch.

Yes, please do. Does it upload a rpm?

@probonopd
Copy link
Member Author

Thanks @TheAssassin, however we are still getting an error:

https://travis-ci.org/AppImage/appimaged/jobs/453558440#L3743

Travis CI still shows "green", even tough upload.sh was not successful.

@TheAssassin
Copy link
Member

Travis CI still shows "green", even tough upload.sh was not successful.

That's the issue with Travis CI. It's always been behaving like that. Real CI servers have different states for this.

@probonopd
Copy link
Member Author

Easy fix: Don't put stuff into after_success but put it in script.

@TheAssassin
Copy link
Member

Travis should simply introduce a "yellow" state...

@probonopd
Copy link
Member Author

True; wanna write a feature request?

@TheAssassin
Copy link
Member

No, I'd rather switch to a real CI system that provides some real features...

@TheAssassin
Copy link
Member

Closed by #27.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help-wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants