Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retro theme navbar added #496

Closed
wants to merge 1 commit into from
Closed

retro theme navbar added #496

wants to merge 1 commit into from

Conversation

kekubhai
Copy link

@kekubhai kekubhai commented Oct 13, 2024 •
edited by Anjaliavv51
Loading

Description

Related Issues

Type of PR

Screenshots / videos (if applicable)

image

Checklist

  • [X ] I have gone through the contributing guide
  • [ X] I have updated my branch and synced it with project main branch before making this PR
  • [ X] I have performed a self-review of my code
  • [X ] I have tested the changes thoroughly before submitting this pull request.
  • [ X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [ X] I have commented my code, particularly in hard-to-understand areas.

Additional context:

@netlify Netlify
Copy link

netlify bot commented Oct 13, 2024 •
edited
Loading

✅ Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit e09af49
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/670bc93b126a4000087676c5
😎 Deploy Preview https://deploy-preview-496--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Oct 13, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @kekubhai! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Anjaliavv51
Copy link
Owner

@kekubhai overflow of navbar.

image

@kekubhai
Copy link
Author

yes I guess I have made a mistake there, Check if this one is fine or not
image

@Anjaliavv51
Copy link
Owner

yes I guess I have made a mistake there, Check if this one is fine or not image

fine but it is not match with UI of html body

@kekubhai
Copy link
Author

yes I guess I have made a mistake there, Check if this one is fine or not image

fine but it is not match with UI of html body

You can ask for create an issue for that and make someone work, people will love to work on that after you merge this one, Or I will just have to discard this as an Issue. Thanks

@Anjaliavv51
Copy link
Owner

yes I guess I have made a mistake there, Check if this one is fine or not image

fine but it is not match with UI of html body

You can ask for create an issue for that and make someone work, people will love to work on that after you merge this one, Or I will just have to discard this as an Issue. Thanks

discard this issue , and carry to raise someother issue , coz if it is implemented it takes not only time , but also irritates aa lot with merge conflicts and bug's , so i am closing this PR and issue Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨[feature Request]: whole template Change
2 participants
@kekubhai @Anjaliavv51