Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests fail massively #73

Open
kdambekalns opened this issue Nov 4, 2015 · 1 comment
Open

Unit tests fail massively #73

kdambekalns opened this issue Nov 4, 2015 · 1 comment

Comments

@kdambekalns
Copy link

The current state of the project is that a lot of tests fail, even on PHP 5.3 and 5.4, as is clearly visible on TravisCI. This is really a bad situation, since it more or less makes it impossible to work on the codebase - you would need a "green bar" before you can do that safely.

I started to look at the tests, but since some tests fail due to functionality added in recent PHP versions, it might make sense to define the way forward first… Would it be an option to drop support for PHP 5.3 and 5.4, and have newer versions support PHP 5.5 and up? This could safely be done by bumping to version 2.0 of the library. For the current state, that would still mean fixing things, so that the tests run again on PHP 5.3 and 5.4, of course.

Any pointers on how to approach this? I would invest some (more) time into this, but would welcome some introduction to the architecture (of the tests), to speed things up.

@jankal
Copy link

jankal commented Mar 12, 2017

As far as I know, this repo is abandoned. There won't be any updates anymore. Even if I'll be trying to keep this up when I have some spare time from ApiGen/ApiGen. But there we'll probably use goaop/parser-reflection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants