Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only video cover picture can be downloaded (Installed on Android) #28

Open
Mogez opened this issue Jul 9, 2023 · 5 comments
Open

Only video cover picture can be downloaded (Installed on Android) #28

Mogez opened this issue Jul 9, 2023 · 5 comments
Labels
bug Something isn't working enhancement New feature or request partially-fixed

Comments

@Mogez
Copy link

Mogez commented Jul 9, 2023

I just installed twitter-click-and-save on Android Vivaldi/Edge using ChromeXt Xposed plugin.
The download button appears fine but it only leads to the cover picture.
Is it possible to support Android phone?
@AlttiRi AlttiRi added bug Something isn't working enhancement New feature or request labels Jul 9, 2023
@AlttiRi
Copy link
Owner

AlttiRi commented Jul 9, 2023 •
edited
Loading

I can reproduce it with simulating a mobile viewport with DevTools on PC.
Seems it because the video does not play automatically in mobile version.
Will take a look how to fix it later.

@Mogez
Copy link
Author

Mogez commented Jul 13, 2023 •
edited
Loading

Will take a look how to fix it later.

Looking forward to your update~ Thanks!

AlttiRi added a commit that referenced this issue Jul 13, 2023
@AlttiRi
Add mobileVideoHandler
d74e7c2 
As a quick fix for #28
@AlttiRi
Copy link
Owner

AlttiRi commented Jul 13, 2023 •
edited
Loading

I wanted to totally refactor the download button's code in some days, but okay, here is a quick fix (temporally): d74e7c2

You can install it (the dev version) from GitHub:
https://github.com/AlttiRi/twitter-click-and-save/raw/master/twitter-click-and-save.user.js

@Mogez
Copy link
Author

Mogez commented Aug 5, 2023

Great ~ Installed and tested, but sometimes it won't work. I can't tell the difference, like this one:
https://twitter.com/CNBC/status/1687750540049145857

@AlttiRi
Copy link
Owner

AlttiRi commented Aug 5, 2023 •
edited
Loading

Should be fixed in 0a4b1b1 ("Embedded video") and 8cf3d19 ("Animated Text GIF").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request partially-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlttiRi @Mogez