Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature vector key discrepancy #19

Open
blogeman opened this issue Oct 8, 2020 · 2 comments
Open

Feature vector key discrepancy #19

blogeman opened this issue Oct 8, 2020 · 2 comments

Comments

@blogeman
Copy link

blogeman commented Oct 8, 2020

One of the inputs to this package is a "feature vector" file generated by the package IPFX using its "run_feature_vector_extraction" script. The types of data generated from IPFX must match the key values listed in the spca_params.json input.

As of IPFX v 1.0 the names of the datasets have changed from what is listed in drcme/config/default_spca_params.json. Below are the discrepancies
Capture
:
Shown in yellow are the dataset keys with the same name while blue indicates a discrepancy in the name. I think I've got them matched up correctly and after getting confirmation I can submit a pull request with the names changed to match the ipfx output.

@gouwens
Copy link
Collaborator

gouwens commented Oct 8, 2020

Thanks for identifying the issue. It looks correct apart from inst_freq - that should match up with the old spiking_inst_freq. The data set inst_freq_norm is actually calculated by DRCME rather than IPFX (since it's directly calculated from inst_freq in the H5 file). And subthresh_depol_norm doesn't have a pre-existing entry in that default parameters file.

@blogeman
Copy link
Author

blogeman commented Oct 9, 2020

Oh that makes more sense now, thanks for clarifying. I've submitted a pull request to change the 3 key names that don't match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants