Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store session ID as a URI param instead of in-memory #4281

Open
amanape opened this issue Oct 8, 2024 · 0 comments
Open

Store session ID as a URI param instead of in-memory #4281

amanape opened this issue Oct 8, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@amanape
Copy link
Member

amanape commented Oct 8, 2024

Motivation
Storing the token as a URI param will make it much more manageable and easier to access (React Router / Remix has a hook useSearchParams that can do just that) throughout the app rather than relying on local storage.

Technical Design
When a new session is created, store the ID as a parameter. Retrieving it is as easy as calling a hook within components, and React Router / Remix data loaders already allow for easy access to the URL and params.

Alternatives to Consider
Keep it in local storage

Additional context
Suggested by @tobitege

@amanape amanape self-assigned this Oct 8, 2024
@mamoodi mamoodi added the enhancement New feature or request label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants