Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Reduce padding in lists inside of messages #4082

Closed
2 tasks done
rbren opened this issue Sep 27, 2024 · 15 comments · Fixed by #4177
Closed
2 tasks done

[Bug]: Reduce padding in lists inside of messages #4082

rbren opened this issue Sep 27, 2024 · 15 comments · Fixed by #4177
Assignees
Labels
bug Something isn't working fix-me Attempt to fix this issue with OpenHands. frontend Related to frontend good first issue Good for newcomers severity:low Minor issues, affecting single user

Comments

@rbren
Copy link
Collaborator

rbren commented Sep 27, 2024

Is there an existing issue for the same bug?

Describe the bug

The spacing here is a little over the top :)
Screenshot 2024-09-27 at 10 39 35 AM

This can probably be fixed by modifying the spacing in frontend/src/index.css

Current OpenHands version

0.9.5

Installation and Configuration

`docker run` from the README

Model and Agent

N/A

Operating System

N/A

Reproduction Steps

Write a prompt that uses markdown bullet points

Logs, Errors, Screenshots, and Additional Context

No response

@rbren rbren added bug Something isn't working good first issue Good for newcomers labels Sep 27, 2024
@enyst enyst added the frontend Related to frontend label Sep 27, 2024
@neubig neubig added the fix-me Attempt to fix this issue with OpenHands. label Sep 28, 2024
Copy link
Contributor

OpenHands started fixing the issue! You can monitor the progress here.

@neubig neubig added fix-me Attempt to fix this issue with OpenHands. and removed fix-me Attempt to fix this issue with OpenHands. labels Sep 28, 2024
Copy link
Contributor

OpenHands started fixing the issue! You can monitor the progress here.

Copy link
Contributor

An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named '' has been created with the attempted changes. You can view the branch here. Manual intervention may be required.

@neubig
Copy link
Contributor

neubig commented Sep 28, 2024

@neubig neubig added fix-me Attempt to fix this issue with OpenHands. and removed fix-me Attempt to fix this issue with OpenHands. labels Sep 28, 2024
Copy link
Contributor

OpenHands started fixing the issue! You can monitor the progress here.

Copy link
Contributor

A potential fix has been generated and a draft PR # has been created. Please review the changes.

@neubig
Copy link
Contributor

neubig commented Sep 28, 2024

Sorry, the message above is incorrect: All-Hands-AI/openhands-resolver#117

I'll fix the resolver and try again.

@neubig neubig added fix-me Attempt to fix this issue with OpenHands. and removed fix-me Attempt to fix this issue with OpenHands. labels Sep 28, 2024
Copy link
Contributor

OpenHands started fixing the issue! You can monitor the progress here.

Copy link
Contributor

An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named 'openhands-fix-issue-4082-try2' has been created with the attempted changes. You can view the branch here. Manual intervention may be required.

@Vaishakh-SM
Copy link
Contributor

Hi!
Can I work on this?

@neubig
Copy link
Contributor

neubig commented Oct 2, 2024

Yes, please go ahead @Vaishakh-SM !

@Vaishakh-SM
Copy link
Contributor

Vaishakh-SM commented Oct 2, 2024

Adding a checklist of items that I intend to complete as a part of this task:

  • Dev Setup efforts (Following the guide)
  • Reproduction of the issue
  • Glance over the frontend code-base, particularly places related to styling.
  • Tweak styling and check if the issue is resolved
  • Raise PR

@tobitege
Copy link
Collaborator

tobitege commented Oct 2, 2024

Hey @Vaishakh-SM
please have a look at #3449 and the comment by @amanape
I never got to do the follow PR. The above should give you a good starting point where to look, I hope.

@mamoodi mamoodi added the severity:low Minor issues, affecting single user label Oct 2, 2024
@Vaishakh-SM
Copy link
Contributor

Hey @Vaishakh-SM please have a look at #3449 and the comment by @amanape I never got to do the follow PR.

Thanks, this helps a lot!

Can I remove the styles that you added to index.css if I add them into the Markdown component like:

      <Markdown
        components={{
          code,
          ul: ({ children }) => (
            <ul className="list-decimal ml-5 pl-2">{children}</ul>
          ),
          ol: ({ children }) => (
            <ol className="list-disc ml-5 pl-2">{children}</ol>
          ),
        }}
      >

@tobitege
Copy link
Collaborator

tobitege commented Oct 2, 2024

Sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix-me Attempt to fix this issue with OpenHands. frontend Related to frontend good first issue Good for newcomers severity:low Minor issues, affecting single user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants