Optionally add time of FIT channels to AO2D #13857

mpuccio · 2025-01-13T07:20:58Z

No description provided.

github-actions · 2025-01-13T07:21:12Z

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

Add output spec

alibuild · 2025-01-13T10:45:16Z

Error while checking build/O2/fullCI for 929d25c at 2025-01-13 11:45:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-sim-challenge-test-latest/log
./mchmidMatch.log[16589:muon-track-writer]: [10:42:35][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
./sim-challenge.logDetected critical problem in logfile aod.log
./sim-challenge.logaod.log:[FATAL] error while setting up workflow in o2-aod-producer-workflow: missing option: enableFITextra (No such node (enableFITextra))
./sim-challenge.log[FATAL] error while setting up workflow in o2-aod-producer-workflow: missing option: enableFITextra (No such node (enableFITextra))
./aod.log[FATAL] error while setting up workflow in o2-aod-producer-workflow: missing option: enableFITextra (No such node (enableFITextra))
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[7984:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[7984:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[7984:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[7984:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[7984:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[7984:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[7984:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[7984:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[7984:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[7984:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[7986:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[7986:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[7986:TRDDigitizer]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
[0 more errors; see full log]

Full log here.

afurs · 2025-01-16T06:57:17Z

Dear @mpuccio , could you please also add uint64_t eventCondition field into FT0's extra table? disk space increasing should be negligible w.r.t. other fields in extra tables. Later I will implement logic which fulfill this new field, just right after your PR merged.

alibuild · 2025-01-17T22:53:33Z

Error while checking build/O2/fullCI for 7b4eade at 2025-01-17 23:53:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-sim-challenge-test-latest/log
./sim-challenge.logDetected critical problem in logfile tpcreco.log
./sim-challenge.logtpcreco.log:[9377:internal-dpl-ccdb-backend]: [22:53:22][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.logtpcreco.log-[9377:internal-dpl-ccdb-backend]: [22:53:22][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-tpc-reco-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[9377:internal-dpl-ccdb-backend]: [22:53:22][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
./sim-challenge.log[9377:internal-dpl-ccdb-backend]: [22:53:22][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/GLO/Config/GRPMagField for 1546300800000 (agent_id: alimetal02.cern.ch-1737154395-lnZZjv) with http code: 0
./sim-challenge.log[9377:internal-dpl-ccdb-backend]: [22:53:22][ERROR] File GLO/Config/GRPMagField could not be retrieved. No more hosts to try.
./sim-challenge.log[9377:internal-dpl-ccdb-backend]: [22:53:22][FATAL] Unable to find object GLO/Config/GRPMagField/1546300800000
./sim-challenge.log[9377:internal-dpl-ccdb-backend]: [22:53:22][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.log[9377:internal-dpl-ccdb-backend]: [22:53:22][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-tpc-reco-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[ERROR] Workflow crashed - PID 9377 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR]  - Device internal-dpl-ccdb-backend: pid 9377 (exit 128)
./sim-challenge.log[INFO]    - First error: [22:53:22][FATAL] Unable to find object GLO/Config/GRPMagField/1546300800000
./sim-challenge.log[ERROR] SEVERE: Device internal-dpl-ccdb-backend (9377) had at least one message above severity 5: Unable to find object GLO/Config/GRPMagField/1546300800000
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[6322:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[6322:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[6322:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[6322:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[6322:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
[0 more errors; see full log]

Full log here.

mpuccio · 2025-01-30T08:09:47Z

@ddobrigk @pzhristov can we merge this? In this way we can start testing. @afurs I will send you an email for the additional field

Framework/Core/include/Framework/AnalysisDataModel.h

jgrosseo · 2025-01-30T08:14:00Z

@pzhristov For me it looks good!

pzhristov · 2025-01-30T08:48:46Z

@jgrosseo For some reason the auto-merging needs additional approval. Would you approve this PR to see if this is enough? If not, I can merge it manually.

jotwinow · 2025-01-30T11:04:12Z

Detectors/AOD/src/AODProducerWorkflowSpec.cxx

  std::vector<uint8_t> aChannels;
  fv0aCursor.reserve(fv0RecPoints.size());
  for (auto& fv0RecPoint : fv0RecPoints) {
    aAmplitudes.clear();
    aChannels.clear();
+    aTimes.clear();
    const auto channelData = fv0RecPoint.getBunchChannelData(fv0ChData);
    for (auto& channel : channelData) {
      if (channel.charge > 0) {


remove this condition on the charge

mpuccio requested review from a team as code owners January 13, 2025 07:20

alibuild mentioned this pull request Jan 13, 2025

Please consider the following formatting changes to #13857 mpuccio/AliceO2#44

Closed

mpuccio force-pushed the mp-branch-2 branch from 929d25c to aa936f1 Compare January 13, 2025 08:58

Optionally add time of FIT channels to AO2D

7b4eade

Add output spec

mpuccio force-pushed the mp-branch-2 branch 2 times, most recently from 2137c13 to 6f539f6 Compare January 13, 2025 10:34

alibuild mentioned this pull request Jan 13, 2025

Please consider the following formatting changes to #13857 mpuccio/AliceO2#45

Closed

mpuccio force-pushed the mp-branch-2 branch from 6f539f6 to 7b4eade Compare January 13, 2025 14:56

jgrosseo reviewed Jan 30, 2025

View reviewed changes

Framework/Core/include/Framework/AnalysisDataModel.h Show resolved Hide resolved

pzhristov approved these changes Jan 30, 2025

View reviewed changes

pzhristov enabled auto-merge (squash) January 30, 2025 08:46

ktf disabled auto-merge January 30, 2025 09:00

ktf merged commit b00bfe5 into AliceO2Group:dev Jan 30, 2025
15 checks passed

jotwinow reviewed Jan 30, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optionally add time of FIT channels to AO2D #13857

Optionally add time of FIT channels to AO2D #13857

mpuccio commented Jan 13, 2025

github-actions bot commented Jan 13, 2025

alibuild commented Jan 13, 2025

afurs commented Jan 16, 2025

alibuild commented Jan 17, 2025

mpuccio commented Jan 30, 2025

jgrosseo commented Jan 30, 2025

pzhristov commented Jan 30, 2025

jotwinow Jan 30, 2025 •

edited

Loading

Optionally add time of FIT channels to AO2D #13857

Optionally add time of FIT channels to AO2D #13857

Conversation

mpuccio commented Jan 13, 2025

github-actions bot commented Jan 13, 2025

alibuild commented Jan 13, 2025

afurs commented Jan 16, 2025

alibuild commented Jan 17, 2025

mpuccio commented Jan 30, 2025

jgrosseo commented Jan 30, 2025

pzhristov commented Jan 30, 2025

jotwinow Jan 30, 2025 • edited Loading

Choose a reason for hiding this comment

jotwinow Jan 30, 2025 •

edited

Loading